[HADOOP-18428] Parameterize platform toolset version

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: common
• Labels: pull-request-available

Environment

Windows 10

• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed

Language

maven

• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 05/Sep/22
• Created: 28/Aug/22 12:40
• Updated: 28/Jan/24 00:11
• Resolved: 30/Aug/22 17:12

Description

The winutils, libwinutils and native project structures are currently defined in .vcxproj and .sln files. For building on Windows, a key parameter is the PlatformToolsetVersion. This gets added by the build system by running dev-support/bin/win-vs-upgrade.cmd. This essentially runs the following command to detect the PlatformToolsetVersion of the currently installed Visual Studio and uses the same for compilation - https://github.com/apache/hadoop/blob/c60a900583d6a8d0494980f4bbbf4f95438b741b/dev-support/bin/win-vs-upgrade.cmd#L38

devenv %%f /upgrade

However, when building with Dockerfile_windows_10, only Visual Studio 2019 Build Tools are available (and not the full IDE). The Visual Studio 2019 Build Tools distribution doesn't contain devenv and thus, the above command fails to run stating that it couldn't find devenv.

To fix this issue, we need the ability to specify the PlatformToolsetVersion as a Maven option, at which point the win-vs-upgrade.cmd won't run and would use the speicified PlatformToolsetVersion against MSBuild.

Issue Links

• is a child of: HADOOP-17193 Compile Hadoop on Windows natively
• links to: GitHub Pull Request #4815