[HADOOP-18196] Remove replace-guava from replacer plugin

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: build
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 08/Apr/22 13:05
• Updated: 28/Jan/24 08:27
• Resolved: 15/Apr/22 14:25

Description

While running the build, realized that all replacer plugin executions run only after "banned-illegal-imports" enforcer plugin.

For instance,

[INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-illegal-imports) @ hadoop-cloud-storage ---
[INFO] 
[INFO] --- replacer:1.5.3:replace (replace-generated-sources) @ hadoop-cloud-storage ---
[INFO] Skipping
[INFO] 
[INFO] --- replacer:1.5.3:replace (replace-sources) @ hadoop-cloud-storage ---
[INFO] Skipping
[INFO] 
[INFO] --- replacer:1.5.3:replace (replace-guava) @ hadoop-cloud-storage ---
[INFO] Replacement run on 0 file.
[INFO]  

Hence, if our source code uses com.google.common, banned-illegal-imports will cause the build failure and replacer plugin would not even get executed.

We should remove it as it is only redundant execution step.

Issue Links

• links to: GitHub Pull Request #4152