[HADOOP-18150] Fix ITestAuditManagerDisabled after S3A audit logging was enabled in HADOOP-18091

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.5
• Fix Version/s: 3.3.5
• Component/s: fs/s3
• Labels: pull-request-available
• Target Version/s: 3.3.5
• Assignee: Mehakmeet Singh
• Reporter: Mehakmeet Singh
• Created: 03/Mar/22 07:01
• Updated: 03/Mar/22 18:58
• Resolved: 03/Mar/22 18:57

Description

In HADOOP-18094, we disabled audit logging by default and introduced an IT which verifies that by default the audit logging is disabled. After HADOOP-18091, we switched the audit logging back on, but that test remained, which now fails since by default we have the audit logging enabled now.

StackTrace:

java.lang.AssertionError: 
Expecting:
  <Service ActiveAuditManagerS3A in state ActiveAuditManagerS3A: STARTED, auditor=LoggingAuditor{ID='38e14ec9-3439-4b8f-a2f6-993514a2ee4a', headerEnabled=true, rejectOutOfSpan=false}}>
to be an instance of:
  <org.apache.hadoop.fs.s3a.audit.impl.NoopAuditManagerS3A>
but was instance of:
  <org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManagerS3A>    at org.apache.hadoop.fs.s3a.audit.ITestAuditManagerDisabled.testAuditorDisabled(ITestAuditManagerDisabled.java:60)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
    at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
    at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.lang.Thread.run(Thread.java:748)

Issue Links

• relates to: HADOOP-18091 S3A auditing leaks memory through ThreadLocal references
• links to: GitHub Pull Request #4044