[HADOOP-18110] ViewFileSystem: Add Support for Localized Trash Root

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0, 2.10.2
• Component/s: common
• Labels: pull-request-available
• Target Version/s: 3.4.0, 2.10.2, 3.2.4, 3.3.5
• Assignee: Xing Lin
• Reporter: Xing Lin
• Created: 01/Feb/22 19:08
• Updated: 21/Jan/24 04:18
• Resolved: 11/Feb/22 01:24

Description

getTrashRoot() in ViewFileSystem calls getTrashRoot() from underlying filesystem, to return the trash root. Most of the time, we get a trash root in user home dir. This can lead to problems when an application wants to delete a file in a mounted point using moveToTrash() in TrashPolicyDefault, because we can not rename across multiple filesystems/hdfs namenodes. 

 

We propose the following extension to getTrashRoot/getTrashRoots in ViewFileSystem: add a flag to return a localized trash root for ViewFileSystem. A localized trash root is a trash root which starts from the root of a mount point (e.g., /mountpointRoot/.Trash/{user}). 

• If CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is not set to true, or
• when the path p is in a snapshot or an encryption zone, return
• the default trash root in user home dir.
  *
• when CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set to true,
• 1) if path p is mounted from the same targetFS as user home dir,
• return a trash root in user home dir.
• 2) else, return a trash root in the mounted targetFS
  *

Issue Links

• links to: GitHub Pull Request #3956
• links to: GitHub Pull Request #3994