Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-18065

ExecutorHelper.logThrowableFromAfterExecute() is too noisy.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.3.1
    • 3.3.2
    • None

    Description

      if (t == null && r instanceof Future<?> && ((Future<?>) r).isDone()) {
        try {
          ((Future<?>) r).get();
        } catch (ExecutionException ee) {
          LOG.warn(
              "Execution exception when running task in " + Thread.currentThread()
                  .getName());
          t = ee.getCause();
        } catch (InterruptedException ie) {
          LOG.warn("Thread (" + Thread.currentThread() + ") interrupted: ", ie);
          Thread.currentThread().interrupt();
        } catch (Throwable throwable) {
          t = throwable;
        }
      }
      
      if (t != null) {
        LOG.warn("Caught exception in thread " + Thread
            .currentThread().getName() + ": ", t);
      } 

      We should downgrade the logging here from warn to debug.

       

      CC stevel@apache.org  mehakmeetSingh 

      Attachments

        Issue Links

          Activity

            People

              mthakur Mukund Thakur
              mthakur Mukund Thakur
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m