[HADOOP-18006] maven-enforcer-plugin's execution of banned-illegal-imports gets overridden in child poms

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: build
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 12/Nov/21 05:18
• Updated: 21/Jan/24 04:32
• Resolved: 15/Nov/21 13:58

Description

When we specify any maven plugin with execution tag in the parent as well as child modules, child module plugin overrides parent plugin. For instance, when banned-illegal-imports is applied for any child module with only one banned import (let’s say Preconditions), then only that banned import is covered by that child module and all imports defined in parent module (e.g Sets, Lists etc) are overridden and they are no longer applied.
After this commit, hadoop-hdfs module will not complain about Sets even if i import it from guava banned imports but on the other hand, hadoop-yarn module doesn’t have any child level banned-illegal-imports defined so yarn modules will fail if Sets guava import is used.
So going forward, it would be good to replace guava imports with Hadoop’s own imports module-by-module and only at the end, we should add new entry to parent pom banned-illegal-imports list.

Issue Links

• links to: GitHub Pull Request #3648