Hadoop Common
  1. Hadoop Common
  2. HADOOP-1795

Task.moveTaskOutputs is escaping special characters in output filenames

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.14.0
    • Fix Version/s: 0.15.0
    • Component/s: None
    • Labels:
      None

      Description

      after a migration from 0.10.1 to 0.14.0, jobs can't generate output files with special characters in their name, just like '[' or ']' for example, because they are escaped during the Task.moveTaskOutputs process.

      For example, if you try to generate an output file named /foo/bar[0], it ends up being named /foo/bar%5B0%5B.

      The culprit is Task.getFinalPath(), when it does relativePath.toString(), where I think it should do relativePath.getPath().

      1. HADOOP-1795.patch
        6 kB
        Frédéric Bertin

        Activity

        Hide
        Doug Cutting added a comment -

        It looks like this dates to HADOOP-1127, in 0.13.

        Can you supply a patch with a unit test? Thanks!

        Show
        Doug Cutting added a comment - It looks like this dates to HADOOP-1127 , in 0.13. Can you supply a patch with a unit test? Thanks!
        Hide
        Frédéric Bertin added a comment -

        here it is (fix + test)

        Show
        Frédéric Bertin added a comment - here it is (fix + test)
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12364765/HADOOP-1795.patch applied and successfully tested against trunk revision r570881. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/646/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/646/console
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Frédéric!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Frédéric!

          People

          • Assignee:
            Frédéric Bertin
            Reporter:
            Frédéric Bertin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development