[HADOOP-17915] ABFS AbfsDelegationTokenManager to generate canonicalServiceName if DT plugin doesn't

• Type: Sub-task
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Affects Version/s: 3.3.1
• Component/s: fs/azure
• Labels: pull-request-available
• Target Version/s: 3.3.9
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 15/Sep/21 12:43
• Updated: 27/Feb/24 11:09

Description

Currently in AbfsDelegationTokenManager, any CustomDelegationTokenManager only provides a canonical service name if it
implements BoundDTExtension and its getCanonicalServiceName() method.

If this doesn't hold, AbfsDelegationTokenManager returns null, which causes AzureBlobFileSystem.getCanonicalServiceName()
to call super.getCanonicalServiceName() *which resolves the IP address of the abfs endpoint, and then the FQDN of that IPAddr

If a storage account is served over >1 endpoint, then the DT will only have a valid service name for one of the possible
endpoints, so only work if all process get the same IP address when the look up the storage account address

Fix

1. DT plugins SHOULD generate the canonical service name
2. If they don't, and DTs are enabled: AbfsDelegationTokenManager to create a default one
3. and AzureBlobFileSystem.getCanonicalServiceName() MUST NOT call superclass.

The default canonical service name of a store will be abfs:// + FsURI.getHost() + "/", so all containers in same storage account has the same service name

abfs://[e-mail]/path

maps to

abfs://stevel-testing.dfs.core.windows.net/ 

This will mean that only one DT will be created per storage a/c; Applications will not need to list all containers which deployed processes will wish to interact with. Today's behaviour, based on rDNS lookup of storage account, is possibly slightly broader in that all storage accounts which map to the same IPAddr share a DT. The proposed scheme will still be much broader than that of S3A, where every bucket has its unique service name, so apps need to list all target filesystems at launch time (easy for MR, source of trouble in spark).

Fix: straightforward.

Test

• no DTs: service name == null
• DTs: will match proposed pattern, even if extension returns null.

Issue Links

• links to: GitHub Pull Request #3442