[HADOOP-17769] Upgrade JUnit to 4.13.2

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1, 3.4.0, 2.10.2, 3.2.3
• Fix Version/s: 3.4.0, 2.10.2, 3.2.3, 3.3.2
• Component/s: build, test
• Labels: pull-request-available
• Target Version/s: 3.4.0, 2.10.2, 3.2.3, 3.3.2
• Hadoop Flags: Reviewed
• Assignee: Ahmed Hussein
• Reporter: Ahmed Hussein
• Created: 21/Jun/21 17:24
• Updated: 11/Feb/24 14:20
• Resolved: 25/Jun/21 17:21

Description

JUnit 4.13.1 has a bug that is reported in Junit issue-1652 Timeout ThreadGroups should not be destroyed

After upgrading Junit to 4.13.1 in HADOOP-17602, TestBlockRecovery started to fail regularly in branch-3.x and branch-2.10.
While investigating the failure in branch-2.10 HDFS-16072, I found out that the bug is the main reason TestBlockRecovery started to fail because the timeout of the Junit would try to close a ThreadGroup that has been already closed which throws the java.lang.IllegalThreadStateException.

The bug has been fixed in Junit-4.13.2

For branch-3.x, HDFS-15940 did not address the root cause of the problem. Eventually, Splitting the TestBlockRecovery hid the bug, but the upgrade needs to be done so that the problem does not show up in another unit test.

Issue Links

• fixes: HDFS-15940 Some tests in TestBlockRecovery are consistently failing
• fixes: HDFS-16072 TestBlockRecovery fails consistently on Branch-2.10
• is caused by: HADOOP-17602 Upgrade JUnit to 4.13.1
• links to: GitHub Pull Request #3130
• links to: GitHub Pull Request #3131
• links to: GitHub Pull Request #3138
• links to: GitHub Pull Request #3139