VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Incompatible change
    • Hide
      Use jetty's Slf4jRequestLog for http request log.

      As a side effect, we remove the dummy HttpRequestLogAppender, just make use of DailyRollingFileAppender. But the DRFA in log4j1 lacks the ability of specifying the max retain files, so there is no retainDays config any more.

      Will add the above ability back after we switch to log4j2's RollingFileAppender.
      Show
      Use jetty's Slf4jRequestLog for http request log. As a side effect, we remove the dummy HttpRequestLogAppender, just make use of DailyRollingFileAppender. But the DRFA in log4j1 lacks the ability of specifying the max retain files, so there is no retainDays config any more. Will add the above ability back after we switch to log4j2's RollingFileAppender.

    Description

      Now the log file name and retain days in HttpRequestLog is configured from log4j.properties. It can be configured from Configuration instead to drop the usage of log4j API.

      ==== Update ====

      Use jetty's Slf4jRequestLogWriter, we can remove the code dependency on log appenders.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            zhangduo Duo Zhang
            aajisaka Akira Ajisaka
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Slack

                  Issue deployment