[HADOOP-17526] Use Slf4jRequestLog for HttpRequestLog

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: common
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Incompatible change

Release Note

Use jetty's Slf4jRequestLog for http request log.

As a side effect, we remove the dummy HttpRequestLogAppender, just make use of DailyRollingFileAppender. But the DRFA in log4j1 lacks the ability of specifying the max retain files, so there is no retainDays config any more.

Will add the above ability back after we switch to log4j2's RollingFileAppender.

• Assignee: Duo Zhang
• Reporter: Akira Ajisaka
• Created: 12/Feb/21 05:38
• Updated: 12/Feb/24 06:36
• Resolved: 10/Mar/22 02:16

Description

Now the log file name and retain days in HttpRequestLog is configured from log4j.properties. It can be configured from Configuration instead to drop the usage of log4j API.

==== Update ====

Use jetty's Slf4jRequestLogWriter, we can remove the code dependency on log appenders.

Issue Links

• relates to: HADOOP-8704 add request logging to jetty/httpserver
• links to: GitHub Pull Request #4050