[HADOOP-17202] Fix findbugs warnings in hadoop-tools on branch-2.10

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.10.1
• Hadoop Flags: Reviewed
• Assignee: Masatake Iwasaki
• Reporter: Masatake Iwasaki
• Created: 11/Aug/20 03:06
• Updated: 18/Aug/20 04:59
• Resolved: 18/Aug/20 04:59

Description

M D UC_USELESS_OBJECT UC: Useless object stored in variable keysToUpdateAsFolder of method org.apache.hadoop.fs.azure.NativeAzureFileSystem.mkdirs(Path, FsPermission, boolean)  At NativeAzureFileSystem.java:[line 3013]
M D DLS_DEAD_LOCAL_STORE DLS: Dead store to op in org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.access(Path, FsAction)  At AzureBlobFileSystemStore.java:[line 901]
M B CO_COMPARETO_INCORRECT_FLOATING Co: org.apache.hadoop.mapred.gridmix.InputStriper$1.compare(Map$Entry, Map$Entry) incorrectly handles double value  At InputStriper.java:[line 136]
M V MS_MUTABLE_COLLECTION_PKGPROTECT MS: org.apache.hadoop.mapred.gridmix.emulators.resourceusage.TotalHeapUsageEmulatorPlugin$DefaultHeapUsageEmulator.heapSpace is a mutable collection which should be package protected  At TotalHeapUsageEmulatorPlugin.java:[line 132]
M D RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT RV: Return value of org.codehaus.jackson.map.ObjectMapper.getJsonFactory() ignored, but method has no side effect  At JsonObjectMapperWriter.java:[line 59]
H D RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT RV: Return value of new org.apache.hadoop.tools.rumen.datatypes.DefaultDataType(String) ignored, but method has no side effect  At MapReduceJobPropertiesParser.java:[line 212]

Issue Links

• depends upon: HADOOP-14400 Fix warnings from spotbugs in hadoop-tools
• is a child of: HADOOP-17095 findbugs warnings building branch-2.10
• is related to: HADOOP-16734 Backport HADOOP-16455- "ABFS: Implement FileSystem.access() method" to branch-2
• links to: GitHub Pull Request #2214