Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-17127

Use RpcMetrics.TIMEUNIT to initialize rpc queueTime and processingTime

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.4, 3.2.2, 2.10.1, 3.3.1, 3.4.0
    • Component/s: common
    • Labels:
      None

      Description

      While making an internal change to use TimeUnit.MICROSECONDS instead of TimeUnit.MILLISECONDS for rpc details, we found that we also had to modify this code in DecayRpcScheduler.addResponseTime() to initialize queueTime and processingTime with the correct units.

          long queueTime = details.get(Timing.QUEUE, TimeUnit.MILLISECONDS);
          long processingTime = details.get(Timing.PROCESSING, TimeUnit.MILLISECONDS);
      

      If we change these to use RpcMetrics.TIMEUNIT it is simpler.

      We also found one test case in TestRPC that was assuming the units were milliseconds.

        Attachments

        1. HADOOP-17127.001.patch
          4 kB
          Jim Brennan
        2. HADOOP-17127.002.patch
          4 kB
          Jim Brennan
        3. HADOOP-17127-branch-2.10.001.patch
          3 kB
          Jim Brennan
        4. HADOOP-17127-branch-3.1.001.patch
          4 kB
          Jim Brennan
        5. HADOOP-17127-branch-3.2.001.patch
          4 kB
          Jim Brennan

          Activity

            People

            • Assignee:
              Jim_Brennan Jim Brennan
              Reporter:
              Jim_Brennan Jim Brennan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: