[HADOOP-17109] add guava BaseEncoding to illegalClasses

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: build, common
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Ahmed Hussein
• Reporter: Ahmed Hussein
• Created: 01/Jul/20 14:25
• Updated: 12/Feb/24 01:19
• Resolved: 17/Feb/21 01:21

Description

One important thing to not here as pointed out by jeagles in his comment on the parent task

One note to be careful about is that base64 translation is not a standard, so the two implementations could produce different results. This might matter in the case of serialization, persistence, or client server different versions.

Base64Url:

Targets
    Occurrences of 'base64Url' in project with mask '*.java'
Found Occurrences  (6 usages found)
    org.apache.hadoop.mapreduce  (3 usages found)
        CryptoUtils.java  (3 usages found)
            wrapIfNecessary(Configuration, FSDataOutputStream, boolean)  (1 usage found)
                138 + Base64.encodeBase64URLSafeString(iv) + "]");
            wrapIfNecessary(Configuration, InputStream, long)  (1 usage found)
                183 + Base64.encodeBase64URLSafeString(iv) + "]");
            wrapIfNecessary(Configuration, FSDataInputStream)  (1 usage found)
                218 + Base64.encodeBase64URLSafeString(iv) + "]");
    org.apache.hadoop.util  (2 usages found)
        KMSUtil.java  (2 usages found)
            toJSON(KeyVersion)  (1 usage found)
                104 Base64.encodeBase64URLSafeString(
            toJSON(EncryptedKeyVersion)  (1 usage found)
                117 .encodeBase64URLSafeString(encryptedKeyVersion.getEncryptedKeyIv()));
    org.apache.hadoop.yarn.server.resourcemanager.webapp  (1 usage found)
        TestRMWebServicesAppsModification.java  (1 usage found)
            testAppSubmit(String, String)  (1 usage found)
                837 .put("test", Base64.encodeBase64URLSafeString("value12".getBytes("UTF8")));

Base64:

Targets
    Occurrences of 'base64;' in project with mask '*.java'
Found Occurrences  (51 usages found)
    org.apache.hadoop.crypto.key.kms  (1 usage found)
        KMSClientProvider.java  (1 usage found)
            20 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.crypto.key.kms.server  (1 usage found)
        KMS.java  (1 usage found)
            22 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.fs  (2 usages found)
        XAttrCodec.java  (2 usages found)
            23 import org.apache.commons.codec.binary.Base64;
            56 BASE64;
    org.apache.hadoop.fs.azure  (3 usages found)
        AzureBlobStorageTestAccount.java  (1 usage found)
            23 import com.microsoft.azure.storage.core.Base64;
        BlockBlobAppendStream.java  (1 usage found)
            50 import org.apache.commons.codec.binary.Base64;
        ITestBlobDataValidation.java  (1 usage found)
            50 import com.microsoft.azure.storage.core.Base64;
    org.apache.hadoop.fs.azurebfs  (2 usages found)
        AzureBlobFileSystemStore.java  (1 usage found)
            99 import org.apache.hadoop.fs.azurebfs.utils.Base64;
        TestAbfsConfigurationFieldsValidation.java  (1 usage found)
            34 import org.apache.hadoop.fs.azurebfs.utils.Base64;
    org.apache.hadoop.fs.azurebfs.diagnostics  (2 usages found)
        Base64StringConfigurationBasicValidator.java  (1 usage found)
            26 import org.apache.hadoop.fs.azurebfs.utils.Base64;
        TestConfigurationValidators.java  (1 usage found)
            25 import org.apache.hadoop.fs.azurebfs.utils.Base64;
    org.apache.hadoop.fs.azurebfs.extensions  (2 usages found)
        MockDelegationSASTokenProvider.java  (1 usage found)
            37 import org.apache.hadoop.fs.azurebfs.utils.Base64;
        MockSASTokenProvider.java  (1 usage found)
            27 import org.apache.hadoop.fs.azurebfs.utils.Base64;
    org.apache.hadoop.fs.azurebfs.services  (1 usage found)
        SharedKeyCredentials.java  (1 usage found)
            47 import org.apache.hadoop.fs.azurebfs.utils.Base64;
    org.apache.hadoop.fs.cosn  (1 usage found)
        CosNativeFileSystemStore.java  (1 usage found)
            61 import com.qcloud.cos.utils.Base64;
    org.apache.hadoop.fs.s3a  (1 usage found)
        EncryptionTestUtils.java  (1 usage found)
            26 import org.apache.commons.net.util.Base64;
    org.apache.hadoop.hdfs.protocol.datatransfer.sasl  (3 usages found)
        DataTransferSaslUtil.java  (1 usage found)
            39 import org.apache.commons.codec.binary.Base64;
        SaslDataTransferClient.java  (1 usage found)
            47 import org.apache.commons.codec.binary.Base64;
        SaslDataTransferServer.java  (1 usage found)
            44 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.hdfs.server.common.blockaliasmap.impl  (1 usage found)
        TextFileRegionAliasMap.java  (1 usage found)
            31 import java.util.Base64;
    org.apache.hadoop.hdfs.server.federation.store.driver.impl  (1 usage found)
        StateStoreSerializerPBImpl.java  (1 usage found)
            22 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.hdfs.server.federation.store.protocol.impl.pb  (1 usage found)
        FederationProtocolPBTranslator.java  (1 usage found)
            23 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.hdfs.server.namenode.web.resources  (1 usage found)
        NamenodeWebHdfsMethods.java  (1 usage found)
            31 import java.util.Base64;
    org.apache.hadoop.hdfs.web  (1 usage found)
        WebHdfsFileSystem.java  (1 usage found)
            43 import java.util.Base64;
    org.apache.hadoop.io  (1 usage found)
        DefaultStringifier.java  (1 usage found)
            26 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.io.compress  (1 usage found)
        TestCodec.java  (1 usage found)
            51 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.mapreduce  (1 usage found)
        CryptoUtils.java  (1 usage found)
            24 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.mapreduce.security  (1 usage found)
        SecureShuffleUtils.java  (1 usage found)
            29 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.registry.server.dns  (2 usages found)
        RegistryDNS.java  (1 usage found)
            22 import org.apache.commons.net.util.Base64;
        TestRegistryDNS.java  (1 usage found)
            19 import org.apache.commons.net.util.Base64;
    org.apache.hadoop.security  (1 usage found)
        SaslRpcServer.java  (1 usage found)
            42 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.security.authentication.client  (2 usages found)
        KerberosAuthenticator.java  (2 usages found)
            18 import org.apache.commons.codec.binary.Base64;
            152 private Base64 base64;
    org.apache.hadoop.security.authentication.server  (5 usages found)
        KerberosAuthenticationHandler.java  (1 usage found)
            19 import org.apache.commons.codec.binary.Base64;
        LdapAuthenticationHandler.java  (1 usage found)
            34 import org.apache.commons.codec.binary.Base64;
        TestKerberosAuthenticationHandler.java  (1 usage found)
            20 import org.apache.commons.codec.binary.Base64;
        TestLdapAuthenticationHandler.java  (1 usage found)
            24 import org.apache.commons.codec.binary.Base64;
        TestMultiSchemeAuthenticationHandler.java  (1 usage found)
            33 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.security.authentication.util  (2 usages found)
        Signer.java  (1 usage found)
            16 import org.apache.commons.codec.binary.Base64;
        TestKerberosUtil.java  (1 usage found)
            26 import java.util.Base64;
    org.apache.hadoop.security.token  (1 usage found)
        Token.java  (1 usage found)
            24 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.util  (1 usage found)
        KMSUtil.java  (1 usage found)
            20 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.yarn.applications.distributedshell  (2 usages found)
        ApplicationMaster.java  (1 usage found)
            44 import java.util.Base64;
        Client.java  (1 usage found)
            34 import java.util.Base64;
    org.apache.hadoop.yarn.client.util  (1 usage found)
        YarnClientUtils.java  (1 usage found)
            29 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher  (1 usage found)
        TestContainerLaunch.java  (1 usage found)
            59 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.yarn.server.resourcemanager.webapp  (2 usages found)
        RMWebAppUtil.java  (1 usage found)
            30 import org.apache.commons.codec.binary.Base64;
        TestRMWebServicesAppsModification.java  (1 usage found)
            52 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.yarn.service.client  (1 usage found)
        ApiServiceClient.java  (1 usage found)
            35 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.yarn.service.utils  (1 usage found)
        HttpUtil.java  (1 usage found)
            30 import org.apache.commons.codec.binary.Base64;
    org.apache.hadoop.yarn.util  (1 usage found)
        AuxiliaryServiceHelper.java  (1 usage found)
            24 import org.apache.commons.codec.binary.Base64;

Issue Links

• links to: GitHub Pull Request #2703