[HADOOP-17081] MetricsSystem doesn't start the sink adapters on restart

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.2.2, 3.3.1
• Component/s: metrics

Environment

NA

• Assignee: Madhusoodan
• Reporter: Madhusoodan
• Created: 22/Jun/20 14:06
• Updated: 14/Jan/21 10:59
• Resolved: 06/Jul/20 15:30

Description

In HBase we use dynamic metrics and when a metric is removed, we have to refresh the JMX beans, since there is no API from Java to do it, a hack like stopping the metrics system and restarting it was used (Read the comment on the class https://github.com/mmpataki/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java)

 

It calls the below APIs in the same order

     MetricsSystem.stop

     MetricsSystem.start

 

MetricsSystem.stop stops all the SinkAdapters, but doesn't remove them from the sink list (allSinks is the variable). When the metrics system is started again, it is assumed that the SinkAdapters are restarted, but they are not due to the check done in the beginning of the function register.

Issue Links

• is related to: HADOOP-17468 NullPointerException from register in MetricsSystemImpl
• relates to: HADOOP-17329 mvn site commands fails due to MetricsSystemImpl changes
• links to: HADOOP-17081. MetricsSystem doesn't start the sink adapters on restart