[HADOOP-16727] KMS Jetty server does not startup if trust store password is null

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: common
• Target Version/s: 3.3.0, 3.1.4, 3.2.2
• Assignee: Hanisha Koneru
• Reporter: Hanisha Koneru
• Created: 01/Nov/19 22:29
• Updated: 08/Jan/20 00:01
• Resolved: 07/Jan/20 23:47

Description

In HttpServe2, if the trustStore is set but the trust store password is not, then we set the TrustStorePassword of SSLContextFactory to null. This results in the Jetty server not starting up.

In HttpServer2#createHttpsChannelConnector(),

if (trustStore != null) {
  sslContextFactory.setTrustStorePath(trustStore);
  sslContextFactory.setTrustStoreType(trustStoreType);
  sslContextFactory.setTrustStorePassword(trustStorePassword);
}

Before setting the trust store password, we should check that it is not null.