[HADOOP-16717] Remove GenericsUtil isLog4jLogger dependency on Log4jLoggerAdapter

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.2.3
• Hadoop Flags: Reviewed
• Assignee: Xieming Li
• Reporter: David Mollitor
• Created: 16/Nov/19 18:19
• Updated: 28/Feb/22 01:59
• Resolved: 25/Nov/19 05:38

Description

Remove this method:

  /**
   * Determine whether the log of <code>clazz</code> is Log4j implementation.
   * @param clazz a class to be determined
   * @return true if the log of <code>clazz</code> is Log4j implementation.
   */
  public static boolean isLog4jLogger(Class<?> clazz) {
    if (clazz == null) {
      return false;
    }
    Logger log = LoggerFactory.getLogger(clazz);
    return log instanceof Log4jLoggerAdapter;
  }

This creates a dependency on Log4jLoggerAdapter (slf4j-log4j12) which means that any project which depends on hadoop-commons needs to carry this dependency as well. Such a simple use case and such a heavy dependency. The commons library should not depend on any specific implementation of SLF4J binding

Issue Links

• blocks: HADOOP-16716 slf4j-log4j12 Should Not Be Included as Dependency