[HADOOP-16621] [pb-upgrade] Remove Protobuf classes from signatures of Public APIs

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.3.0
• Component/s: common
• Target Version/s: 3.3.0
• Hadoop Flags: Incompatible change, Reviewed

Release Note

Following APIs have been removed from Token.java to avoid protobuf classes in signature.
1. o.a.h.security.token.Token(TokenProto tokenPB)
2. o.a.h.security.token.Token.toTokenProto()

• Assignee: Vinayakumar B
• Reporter: Steve Loughran
• Created: 01/Oct/19 12:26
• Updated: 01/May/20 19:49
• Resolved: 16/Jan/20 18:16

Description

the move to protobuf 3.x stops spark building because Token has a method which returns a protobuf, and now its returning some v3 types.

if we want to isolate downstream code from protobuf changes, we need to move that marshalling method from token and put in a helper class.

Issue Links

• is related to: HADOOP-15059 3.0 deployment cannot work with old version MR tar ball which breaks rolling upgrade
• is related to: HADOOP-12563 Updated utility to create/modify token files
• links to: GitHub Pull Request #1803