Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-16310

Log of a slow RPC request should contain the parameter of the request

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.1.1, 2.7.7, 3.1.2
    • Fix Version/s: None
    • Component/s: rpc-server
    • Labels:
      None
    • Target Version/s:

      Description

       Now, the log of  a slow RPC request just contains the methodName,processingTime and client. Code is here:

      if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
          (processingTime > threeSigma)) {
        if(LOG.isWarnEnabled()) {
          String client = CurCall.get().toString();
          LOG.warn(
              "Slow RPC : " + methodName + " took " + processingTime +
                  " milliseconds to process from client " + client);
        }
        rpcMetrics.incrSlowRpc();
      }

       

      It is not enough to analyze why the RPC request is slow. 

      The parameter of the request is a very important thing, and need to be logged.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                lindongdong lindongdong
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: