[HADOOP-16310] Log of a slow RPC request should contain the parameter of the request

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 3.1.1, 2.7.7, 3.1.2
• Component/s: rpc-server
• Target Version/s: 3.1.4
• Assignee: Unassigned
• Reporter: lindongdong
• Created: 12/May/19 11:00
• Updated: 01/Oct/19 15:02
• Resolved: 01/Oct/19 15:00

Description

 Now, the log of  a slow RPC request just contains the methodName,processingTime and client. Code is here:

if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
    (processingTime > threeSigma)) {
  if(LOG.isWarnEnabled()) {
    String client = CurCall.get().toString();
    LOG.warn(
        "Slow RPC : " + methodName + " took " + processingTime +
            " milliseconds to process from client " + client);
  }
  rpcMetrics.incrSlowRpc();
}

 

It is not enough to analyze why the RPC request is slow. 

The parameter of the request is a very important thing, and need to be logged.

Issue Links

• is duplicated by: HADOOP-16531 Log more detail for slow RPC