[HADOOP-16218] findbugs warning of null param to non-nullable method in Configuration with Guava update

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.3.0
• Component/s: build
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 28/Mar/19 16:41
• Updated: 03/Apr/19 08:21
• Resolved: 02/Apr/19 08:52

Description

Findbugs is fussing over some unchanged code in configuration

Null passed for non-null parameter of writeXml(String, Writer) in org.apache.hadoop.conf.Configuration.writeXml(Writer)
Bug type NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS (click for details) 
In class org.apache.hadoop.conf.Configuration
In method org.apache.hadoop.conf.Configuration.writeXml(Writer)
Called method org.apache.hadoop.conf.Configuration.writeXml(String, Writer)
At Configuration.java:[line 3490]
Argument 1 is definitely null but must not be null
Definite null passed to dangerous method call target org.apache.hadoop.conf.Configuration.writeXml(String, Writer)

Code looks fine; it's invoking Guava.Strings for the check for string == empty-or-null; maybe something changed there.

Proposed: add @Nullable in Configuration writeXml

Issue Links

• is required by: HADOOP-16210 Update guava to 27.0-jre in hadoop-project trunk
• links to: GitHub Pull Request #655