Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15960 Update guava to 27.0-jre in hadoop-project
  3. HADOOP-16218

findbugs warning of null param to non-nullable method in Configuration with Guava update

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.0
    • Fix Version/s: 3.3.0
    • Component/s: build
    • Labels:
      None

      Description

      Findbugs is fussing over some unchanged code in configuration

      Null passed for non-null parameter of writeXml(String, Writer) in org.apache.hadoop.conf.Configuration.writeXml(Writer)
      Bug type NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS (click for details) 
      In class org.apache.hadoop.conf.Configuration
      In method org.apache.hadoop.conf.Configuration.writeXml(Writer)
      Called method org.apache.hadoop.conf.Configuration.writeXml(String, Writer)
      At Configuration.java:[line 3490]
      Argument 1 is definitely null but must not be null
      Definite null passed to dangerous method call target org.apache.hadoop.conf.Configuration.writeXml(String, Writer)
      

      Code looks fine; it's invoking Guava.Strings for the check for string == empty-or-null; maybe something changed there.

      Proposed: add @Nullable in Configuration writeXml

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment