[HADOOP-15748] S3 listing inconsistency can raise NPE in globber

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.1, 2.8.4
• Fix Version/s: 2.10.0, 3.2.0, 3.0.4, 3.1.2
• Component/s: fs
• Target Version/s: 2.10.0, 3.1.2
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 12/Sep/18 10:07
• Updated: 26/Jul/19 20:13
• Resolved: 20/Sep/18 12:07

Description

FileSystem Globber does a listStatus(path) and then, if only one element is returned, getFileStatus(path).isDirectory() to see if it is a dir. The way getFileStatus() is wrapped, IOEs are downgraded to null

On S3, if the path has had entries deleted, the listing may include files which are no longer there, so the getFileStatus(path),isDirectory triggers an NPE

While its wrong to glob against S3 when its being inconsistent, we should at least fail gracefully here.

Proposed

1. log all IOEs raised in Globber.getFileStatus @ debug
2. catch FNFEs and downgrade to warn
3. continue

The alternative would be fail fast on FNFE, but that's more traumatic

Issue Links

• is related to: HADOOP-16458 LocatedFileStatusFetcher scans failing intermittently against S3 store
• is related to: HADOOP-8870 NullPointerException when glob doesn't return files