[HADOOP-15675] checkstyle suppressions files are cached

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: build
• Assignee: Unassigned
• Reporter: Kitti Nanasi
• Created: 09/Aug/18 20:55
• Updated: 22/Aug/18 09:30

Description

If a patch is created with checkstyle errors, for example when a modified line is longer than 80 characters, then running checkstyle with the test-patch script runs to success (though it should fail and show an error about the long line).

dev-support/bin/test-patch  --plugins="-checkstyle" test.patch

However it does show the error (so works correctly) when running it with the IDEA checkstyle plugin.

 

I only tried it out it for patches with too long lines and wrong indentation, but I assume that it can be a more general problem.

We realised this when reviewing HDFS-13217, where patch 004 has a "too long line" checkstyle error. In the first build for that patch, the checkstyle report was showing the error, but when it was ran again with the same patch, the error disappeared. So probably the checkstyle checking stopped working on trunk somewhere between April and July 2018.

Issue Links

• is caused by: HDDS-119 Skip Apache license header check for some ozone doc scripts
• relates to: YETUS-660 checkstyle should report when it fails to execute