Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.1.0
    • 3.2.0, 3.1.1
    • None
    • None
    • Reviewed

    Description

      Currently, FileUtil#readLink has no unit tests.

      Attachments

        1. HADOOP-15516.v1.patch
          3 kB
          Giovanni Matteo Fumarola

        Issue Links

          Activity

            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 20s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 26m 1s trunk passed
            +1 compile 28m 11s trunk passed
            +1 checkstyle 0m 53s trunk passed
            +1 mvnsite 1m 12s trunk passed
            +1 shadedclient 12m 55s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 31s trunk passed
            +1 javadoc 1m 0s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 52s the patch passed
            +1 compile 27m 47s the patch passed
            +1 javac 27m 47s the patch passed
            +1 checkstyle 0m 50s the patch passed
            +1 mvnsite 1m 13s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 10m 58s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 48s the patch passed
            +1 javadoc 1m 0s the patch passed
                  Other Tests
            +1 unit 9m 13s hadoop-common in the patch passed.
            +1 asflicense 0m 36s The patch does not generate ASF License warnings.
            125m 52s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd
            JIRA Issue HADOOP-15516
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12926813/HADOOP-15516.v1.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux b57e43469e42 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4 19:09:19 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / db81f85
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_171
            findbugs v3.1.0-RC1
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14736/testReport/
            Max. process+thread count 1624 (vs. ulimit of 10000)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14736/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 26m 1s trunk passed +1 compile 28m 11s trunk passed +1 checkstyle 0m 53s trunk passed +1 mvnsite 1m 12s trunk passed +1 shadedclient 12m 55s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 31s trunk passed +1 javadoc 1m 0s trunk passed       Patch Compile Tests +1 mvninstall 0m 52s the patch passed +1 compile 27m 47s the patch passed +1 javac 27m 47s the patch passed +1 checkstyle 0m 50s the patch passed +1 mvnsite 1m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 58s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 48s the patch passed +1 javadoc 1m 0s the patch passed       Other Tests +1 unit 9m 13s hadoop-common in the patch passed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 125m 52s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd JIRA Issue HADOOP-15516 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12926813/HADOOP-15516.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux b57e43469e42 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4 19:09:19 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / db81f85 maven version: Apache Maven 3.3.9 Default Java 1.8.0_171 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14736/testReport/ Max. process+thread count 1624 (vs. ulimit of 10000) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14736/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            The run looks clean and the new unit tests run with no issues here.
            +1 on HADOOP-15516.v1.patch.
            We should commit this to trunk directly.

            elgoiri Íñigo Goiri added a comment - The run looks clean and the new unit tests run with no issues here . +1 on HADOOP-15516.v1.patch . We should commit this to trunk directly.

            Thanks giovanni.fumarola for adding the test cases.
            Committed to trunk and branch-3.1.

            elgoiri Íñigo Goiri added a comment - Thanks giovanni.fumarola for adding the test cases. Committed to trunk and branch-3.1.
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14383 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14383/)
            HADOOP-15516. Add test cases to cover FileUtil#readLink. Contributed by (inigoiri: rev 12be8bad7debd67c9ea72b979a39c8cf42c5f37d)

            • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
            • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14383 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14383/ ) HADOOP-15516 . Add test cases to cover FileUtil#readLink. Contributed by (inigoiri: rev 12be8bad7debd67c9ea72b979a39c8cf42c5f37d) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

            I'm not sure exactly when but the unit tests in Windows are failing around these changes:
            https://builds.apache.org/job/hadoop-trunk-win/520/testReport/org.apache.hadoop.fs/TestFileUtil/

            elgoiri Íñigo Goiri added a comment - I'm not sure exactly when but the unit tests in Windows are failing around these changes: https://builds.apache.org/job/hadoop-trunk-win/520/testReport/org.apache.hadoop.fs/TestFileUtil/

            People

              giovanni.fumarola Giovanni Matteo Fumarola
              giovanni.fumarola Giovanni Matteo Fumarola
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: