Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15295

Remove redundant logging related to tags from Configuration

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.2.0
    • None
    • None
    • Reviewed

    Description

      Remove redundant logging related to tags from Configuration.

      2018-03-06 18:55:46,164 INFO conf.Configuration: Removed undeclared tags:
      2018-03-06 18:55:46,237 INFO conf.Configuration: Removed undeclared tags:
      2018-03-06 18:55:46,249 INFO conf.Configuration: Removed undeclared tags:
      2018-03-06 18:55:46,256 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
      

      Attachments

        1. HADOOP-15295.002.patch
          5 kB
          Ajay Kumar
        2. HADOOP-15295.001.patch
          5 kB
          Ajay Kumar
        3. HADOOP-15295.000.patch
          4 kB
          Ajay Kumar

        Issue Links

          Activity

            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 15m 28s trunk passed
            +1 compile 12m 43s trunk passed
            +1 checkstyle 0m 45s trunk passed
            +1 mvnsite 1m 1s trunk passed
            +1 shadedclient 10m 44s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 20s trunk passed
            +1 javadoc 0m 47s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 40s the patch passed
            +1 compile 11m 33s the patch passed
            +1 javac 11m 33s the patch passed
            -0 checkstyle 0m 45s hadoop-common-project/hadoop-common: The patch generated 1 new + 244 unchanged - 0 fixed = 245 total (was 244)
            +1 mvnsite 0m 57s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 8m 44s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 31s the patch passed
            +1 javadoc 0m 58s the patch passed
                  Other Tests
            +1 unit 7m 58s hadoop-common in the patch passed.
            +1 asflicense 0m 25s The patch does not generate ASF License warnings.
            76m 21s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f
            JIRA Issue HADOOP-15295
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12913459/HADOOP-15295.000.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 80467bdf5254 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 19ae442
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14278/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14278/testReport/
            Max. process+thread count 1432 (vs. ulimit of 10000)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14278/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 28s trunk passed +1 compile 12m 43s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 1s trunk passed +1 shadedclient 10m 44s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 20s trunk passed +1 javadoc 0m 47s trunk passed       Patch Compile Tests +1 mvninstall 0m 40s the patch passed +1 compile 11m 33s the patch passed +1 javac 11m 33s the patch passed -0 checkstyle 0m 45s hadoop-common-project/hadoop-common: The patch generated 1 new + 244 unchanged - 0 fixed = 245 total (was 244) +1 mvnsite 0m 57s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 8m 44s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 58s the patch passed       Other Tests +1 unit 7m 58s hadoop-common in the patch passed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 76m 21s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f JIRA Issue HADOOP-15295 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12913459/HADOOP-15295.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 80467bdf5254 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 19ae442 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14278/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14278/testReport/ Max. process+thread count 1432 (vs. ulimit of 10000) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14278/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            ajayydv Ajay Kumar added a comment -

            Patch v1 which wraps tag related functions in try catch to remove any unintended impact no Configuration obj.

            ajayydv Ajay Kumar added a comment - Patch v1 which wraps tag related functions in try catch to remove any unintended impact no Configuration obj.
            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 18s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 15m 50s trunk passed
            +1 compile 12m 39s trunk passed
            +1 checkstyle 0m 44s trunk passed
            +1 mvnsite 1m 7s trunk passed
            +1 shadedclient 10m 41s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 24s trunk passed
            +1 javadoc 0m 52s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 51s the patch passed
            +1 compile 13m 3s the patch passed
            +1 javac 13m 3s the patch passed
            +1 checkstyle 0m 46s the patch passed
            +1 mvnsite 1m 2s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 9m 40s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 41s the patch passed
            +1 javadoc 0m 50s the patch passed
                  Other Tests
            +1 unit 8m 30s hadoop-common in the patch passed.
            +1 asflicense 0m 30s The patch does not generate ASF License warnings.
            80m 3s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f
            JIRA Issue HADOOP-15295
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12914804/HADOOP-15295.001.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 8a32fe78e56f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 4bf6220
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14321/testReport/
            Max. process+thread count 1378 (vs. ulimit of 10000)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14321/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 50s trunk passed +1 compile 12m 39s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 7s trunk passed +1 shadedclient 10m 41s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 24s trunk passed +1 javadoc 0m 52s trunk passed       Patch Compile Tests +1 mvninstall 0m 51s the patch passed +1 compile 13m 3s the patch passed +1 javac 13m 3s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 1m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 40s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 41s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests +1 unit 8m 30s hadoop-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 80m 3s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f JIRA Issue HADOOP-15295 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12914804/HADOOP-15295.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 8a32fe78e56f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 4bf6220 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14321/testReport/ Max. process+thread count 1378 (vs. ulimit of 10000) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14321/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            xyao Xiaoyu Yao added a comment -

            Thanks ajayydv for working on this. The patch looks good to me overall. I just have one question:

             

            Configuration.java

            Line 3187: can we keep the addTags() API simple as documented on line 3183 without the additional varagrs? Different components can add customized tags via HADOOP_CUSTOM_TAGS.

             

            xyao Xiaoyu Yao added a comment - Thanks ajayydv for working on this. The patch looks good to me overall. I just have one question:   Configuration.java Line 3187: can we keep the addTags() API simple as documented on line 3183 without the additional varagrs? Different components can add customized tags via HADOOP_CUSTOM_TAGS.  
            ajayydv Ajay Kumar added a comment -

            xyao, thanks for review. Removed var args in patch v2.

            ajayydv Ajay Kumar added a comment - xyao , thanks for review. Removed var args in patch v2.
            xyao Xiaoyu Yao added a comment -

            Thanks ajayydv for the update. Patch v2 looks good to me. +1 pending Jenkins.

            xyao Xiaoyu Yao added a comment - Thanks ajayydv for the update. Patch v2 looks good to me. +1 pending Jenkins.
            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 27s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 22m 33s trunk passed
            +1 compile 26m 11s trunk passed
            +1 checkstyle 0m 39s trunk passed
            +1 mvnsite 0m 59s trunk passed
            +1 shadedclient 9m 40s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 22s trunk passed
            +1 javadoc 0m 47s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 44s the patch passed
            +1 compile 25m 9s the patch passed
            +1 javac 25m 9s the patch passed
            +1 checkstyle 0m 41s the patch passed
            +1 mvnsite 0m 59s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 8m 4s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 30s the patch passed
            +1 javadoc 0m 45s the patch passed
                  Other Tests
            -1 unit 8m 6s hadoop-common in the patch failed.
            +1 asflicense 0m 25s The patch does not generate ASF License warnings.
            108m 33s



            Reason Tests
            Failed junit tests hadoop.fs.TestTrash



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b
            JIRA Issue HADOOP-15295
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12915979/HADOOP-15295.002.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 20a2c63f6449 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 647058e
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            unit https://builds.apache.org/job/PreCommit-HADOOP-Build/14382/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14382/testReport/
            Max. process+thread count 1441 (vs. ulimit of 10000)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14382/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 22m 33s trunk passed +1 compile 26m 11s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 0m 59s trunk passed +1 shadedclient 9m 40s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 22s trunk passed +1 javadoc 0m 47s trunk passed       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 25m 9s the patch passed +1 javac 25m 9s the patch passed +1 checkstyle 0m 41s the patch passed +1 mvnsite 0m 59s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 8m 4s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 45s the patch passed       Other Tests -1 unit 8m 6s hadoop-common in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 108m 33s Reason Tests Failed junit tests hadoop.fs.TestTrash Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b JIRA Issue HADOOP-15295 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12915979/HADOOP-15295.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 20a2c63f6449 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 647058e maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/14382/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14382/testReport/ Max. process+thread count 1441 (vs. ulimit of 10000) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14382/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            aengineer Anu Engineer added a comment -

            ajayydv Thank you for the contribution. I have committed this to the trunk.

            aengineer Anu Engineer added a comment - ajayydv Thank you for the contribution. I have committed this to the trunk.
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13874 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13874/)
            HADOOP-15295. Remove redundant logging related to tags from (aengineer: rev 28790b81ecb719ac26a01ad0c400ee5f1c29ccf8)

            • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
            • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13874 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13874/ ) HADOOP-15295 . Remove redundant logging related to tags from (aengineer: rev 28790b81ecb719ac26a01ad0c400ee5f1c29ccf8) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
            ajayydv Ajay Kumar added a comment -

            xyao,anu thanks for review and commit.

            ajayydv Ajay Kumar added a comment - xyao , anu thanks for review and commit.

            People

              ajayydv Ajay Kumar
              ajayydv Ajay Kumar
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: