[HADOOP-15252] Checkstyle version is not compatible with IDEA's checkstyle plugin

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0, 3.0.4
• Target Version/s: 3.2.0
• Hadoop Flags: Reviewed
• Release Note: Updated checkstyle to 8.8 and updated maven-checkstyle-plugin to 3.0.0.
• Assignee: Andras Bokor
• Reporter: Andras Bokor
• Created: 22/Feb/18 12:59
• Updated: 19/Dec/19 13:19
• Resolved: 03/Mar/18 01:09

Description

After upgrading to the latest IDEA the IDE throws error messages in every few minutes like

The Checkstyle rules file could not be parsed.
SuppressionCommentFilter is not allowed as a child in Checker
The file has been blacklisted for 60s.

This is caused by some backward incompatible changes in checkstyle source code:
http://checkstyle.sourceforge.net/releasenotes.html

• 8.1: Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker.
• 8.2: remove FileContentsHolder module as FileContents object is available for filters on TreeWalker in TreeWalkerAudit Event.

IDEA uses checkstyle 8.8

We should upgrade our checkstyle version to be compatible with IDEA's checkstyle plugin.
Also it's a good time to upgrade maven-checkstyle-plugin as well to brand new 3.0.