Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15252

Checkstyle version is not compatible with IDEA's checkstyle plugin

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0, 3.0.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Updated checkstyle to 8.8 and updated maven-checkstyle-plugin to 3.0.0.

      Description

      After upgrading to the latest IDEA the IDE throws error messages in every few minutes like

      The Checkstyle rules file could not be parsed.
      SuppressionCommentFilter is not allowed as a child in Checker
      The file has been blacklisted for 60s.

      This is caused by some backward incompatible changes in checkstyle source code:
      http://checkstyle.sourceforge.net/releasenotes.html

      • 8.1: Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker.
      • 8.2: remove FileContentsHolder module as FileContents object is available for filters on TreeWalker in TreeWalkerAudit Event.

      IDEA uses checkstyle 8.8

      We should upgrade our checkstyle version to be compatible with IDEA's checkstyle plugin.
      Also it's a good time to upgrade maven-checkstyle-plugin as well to brand new 3.0.

        Attachments

        1. HADOOP-15252.001.patch
          2 kB
          Andras Bokor
        2. HADOOP-15252.002.patch
          2 kB
          Andras Bokor
        3. HADOOP-15252.003.patch
          2 kB
          Andras Bokor
        4. idea_checkstyle_settings.png
          97 kB
          Zsolt Venczel

          Activity

            People

            • Assignee:
              boky01 Andras Bokor
              Reporter:
              boky01 Andras Bokor
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: