Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15230

org.apache.hadoop.metrics2.GraphiteSink is not implemented correctly

Details

    • Hide
      Corrected problems with GraphiteSink not having proper format in point tags. Format v1.1 suggests point tags should be delimited with ';' rather than '.' and also appear at the end of the metric name, not in the middle. Also removed risk of point tag value having empty space (will be replaced by '_').
      Show
      Corrected problems with GraphiteSink not having proper format in point tags. Format v1.1 suggests point tags should be delimited with ';' rather than '.' and also appear at the end of the metric name, not in the middle. Also removed risk of point tag value having empty space (will be replaced by '_').
    • metrics graphite
    • Patch

    Description

      org.apache.hadoop.metrics2.GraphiteSink's implementation has certain problems that would make it to generate metrics incorrectly.

      The problem lies with line 77 ~ 84 of the GraphiteSink java:

      for (MetricsTag tag : record.tags()) {
      if (tag.value() != null) {
      metricsPathPrefix.append(".");
      metricsPathPrefix.append(tag.name());
      metricsPathPrefix.append("=");
      metricsPathPrefix.append(tag.value());
      }
      }
      

      It produces point tags having name=value pair in the metrics. However, notice how the tags are added with '.' as its delimiters. Rather than using the '.' character, it should follow the following convention mentioned in the latest graphite doc of using ';' character.

      http://graphite.readthedocs.io/en/latest/tags.html

      Also, the value is not properly being escaped, meaning that if the value has a '.' character in it, it will easily confuse Graphite to accept it as a delimiter, rather than the value. A really good prime example is when the value is a hostname or ip address,

      metrics.example.Hostname=this.is.a.hostname.and.this.is.Metrics 10.0

      In this example, the since the value of the hostname contains '.', it is extremely hard for the receiving end to determine which part is hostname and which part is the rest of the metrics name. A good strategy is to convert any '.' character in the value to be converted to other characters, such as '_'.

      However, the best way would be to follow the latest metrics convention of using ';'

      metrics.example.and.this.is.Metrics;Hostname=this.is.a.hostname 10.0

      Attachments

        1. HADOOP-15230.007.patch
          24 kB
          Howard Yoo

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user howardyoo opened a pull request:

            https://github.com/apache/hadoop/pull/340

            fixes GraphiteSink to support point tags in correct format

            Fixed GraphiteSink to support point tags in correct format, having appeared at the end and also having no space as its name and value pair.
            [JIRA Ticket](https://issues.apache.org/jira/browse/HADOOP-15230)

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/howardyoo/hadoop origin/HADOOP-15230

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/hadoop/pull/340.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #340


            commit 70ff7d7bd562df03a86ea8819cac07606ba3b70e
            Author: Howard Yoo <yooh@...>
            Date: 2018-02-14T01:01:02Z

            fixes GraphiteSink to support point tags in correct format

            Fixed GraphiteSink to support point tags in correct format, having appeared at the end and also having no space as its name and value pair.


            githubbot ASF GitHub Bot added a comment - GitHub user howardyoo opened a pull request: https://github.com/apache/hadoop/pull/340 fixes GraphiteSink to support point tags in correct format Fixed GraphiteSink to support point tags in correct format, having appeared at the end and also having no space as its name and value pair. [JIRA Ticket] ( https://issues.apache.org/jira/browse/HADOOP-15230 ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/howardyoo/hadoop origin/ HADOOP-15230 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/340.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #340 commit 70ff7d7bd562df03a86ea8819cac07606ba3b70e Author: Howard Yoo <yooh@...> Date: 2018-02-14T01:01:02Z fixes GraphiteSink to support point tags in correct format Fixed GraphiteSink to support point tags in correct format, having appeared at the end and also having no space as its name and value pair.
            howardyoo Howard Yoo added a comment -

            pushed a new PR to fix this issue at : https://github.com/apache/hadoop/pull/340

             

            howardyoo Howard Yoo added a comment - pushed a new PR to fix this issue at : https://github.com/apache/hadoop/pull/340  
            stevel@apache.org Steve Loughran added a comment -

            you need to hit the submit patch button to have Yetus do a build; things won't get reviewed until its happy about all the redline items, and the orangeline warnings are either addressed or justified

            stevel@apache.org Steve Loughran added a comment - you need to hit the submit patch button to have Yetus do a build; things won't get reviewed until its happy about all the redline items, and the orangeline warnings are either addressed or justified
            howardyoo Howard Yoo added a comment -

            Ok, will do. Thanks!

            howardyoo Howard Yoo added a comment - Ok, will do. Thanks!
            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  trunk Compile Tests
            +1 mvninstall 15m 27s trunk passed
            +1 compile 12m 40s trunk passed
            +1 checkstyle 0m 38s trunk passed
            +1 mvnsite 1m 0s trunk passed
            +1 shadedclient 10m 11s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 15s trunk passed
            +1 javadoc 0m 55s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 39s the patch passed
            +1 compile 11m 14s the patch passed
            +1 javac 11m 14s the patch passed
            -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 7 new + 122 unchanged - 5 fixed = 129 total (was 127)
            +1 mvnsite 1m 6s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 9m 1s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 25s the patch passed
            +1 javadoc 0m 49s the patch passed
                  Other Tests
            -1 unit 7m 23s hadoop-common in the patch failed.
            +1 asflicense 0m 29s The patch does not generate ASF License warnings.
            74m 49s



            Reason Tests
            Failed junit tests hadoop.metrics2.impl.TestGraphiteMetrics



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910686/HADOOP-15230.001.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 449fb820c86d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 8f66aff
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            unit https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/testReport/
            Max. process+thread count 1414 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 27s trunk passed +1 compile 12m 40s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 0s trunk passed +1 shadedclient 10m 11s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 15s trunk passed +1 javadoc 0m 55s trunk passed       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 11m 14s the patch passed +1 javac 11m 14s the patch passed -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 7 new + 122 unchanged - 5 fixed = 129 total (was 127) +1 mvnsite 1m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 1s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 49s the patch passed       Other Tests -1 unit 7m 23s hadoop-common in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 74m 49s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGraphiteMetrics Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910686/HADOOP-15230.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 449fb820c86d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 8f66aff maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/testReport/ Max. process+thread count 1414 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14131/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            howardyoo Howard Yoo added a comment -

            re-submitting patch version 002

            howardyoo Howard Yoo added a comment - re-submitting patch version 002
            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 22s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 18m 22s trunk passed
            +1 compile 15m 2s trunk passed
            +1 checkstyle 0m 41s trunk passed
            +1 mvnsite 1m 7s trunk passed
            +1 shadedclient 11m 55s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 31s trunk passed
            +1 javadoc 0m 53s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 47s the patch passed
            +1 compile 12m 27s the patch passed
            +1 javac 12m 27s the patch passed
            -0 checkstyle 0m 39s hadoop-common-project/hadoop-common: The patch generated 11 new + 247 unchanged - 9 fixed = 258 total (was 256)
            +1 mvnsite 1m 8s the patch passed
            -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
            +1 shadedclient 10m 9s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 36s the patch passed
            +1 javadoc 0m 55s the patch passed
                  Other Tests
            -1 unit 8m 45s hadoop-common in the patch failed.
            +1 asflicense 0m 36s The patch does not generate ASF License warnings.
            86m 39s



            Reason Tests
            Failed junit tests hadoop.metrics2.impl.TestGraphiteMetrics



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910772/HADOOP-15230.002.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 3e4356cc4921 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / da59acd
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/artifact/out/whitespace-eol.txt
            unit https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/testReport/
            Max. process+thread count 1638 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 18m 22s trunk passed +1 compile 15m 2s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 7s trunk passed +1 shadedclient 11m 55s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 31s trunk passed +1 javadoc 0m 53s trunk passed       Patch Compile Tests +1 mvninstall 0m 47s the patch passed +1 compile 12m 27s the patch passed +1 javac 12m 27s the patch passed -0 checkstyle 0m 39s hadoop-common-project/hadoop-common: The patch generated 11 new + 247 unchanged - 9 fixed = 258 total (was 256) +1 mvnsite 1m 8s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedclient 10m 9s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 55s the patch passed       Other Tests -1 unit 8m 45s hadoop-common in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 86m 39s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGraphiteMetrics Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910772/HADOOP-15230.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 3e4356cc4921 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / da59acd maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/artifact/out/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/testReport/ Max. process+thread count 1638 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14135/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 16m 42s trunk passed
            +1 compile 13m 28s trunk passed
            +1 checkstyle 0m 41s trunk passed
            +1 mvnsite 1m 5s trunk passed
            +1 shadedclient 11m 54s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 27s trunk passed
            +1 javadoc 0m 54s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 44s the patch passed
            +1 compile 12m 17s the patch passed
            +1 javac 12m 17s the patch passed
            -0 checkstyle 0m 46s hadoop-common-project/hadoop-common: The patch generated 11 new + 247 unchanged - 9 fixed = 258 total (was 256)
            +1 mvnsite 1m 5s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 10m 6s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 35s the patch passed
            +1 javadoc 0m 55s the patch passed
                  Other Tests
            +1 unit 8m 51s hadoop-common in the patch passed.
            +1 asflicense 0m 34s The patch does not generate ASF License warnings.
            83m 0s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910803/HADOOP-15230.003.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux b4cdbc17ff0c 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 0b489e5
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14140/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14140/testReport/
            Max. process+thread count 1717 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14140/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 16m 42s trunk passed +1 compile 13m 28s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 5s trunk passed +1 shadedclient 11m 54s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 27s trunk passed +1 javadoc 0m 54s trunk passed       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 12m 17s the patch passed +1 javac 12m 17s the patch passed -0 checkstyle 0m 46s hadoop-common-project/hadoop-common: The patch generated 11 new + 247 unchanged - 9 fixed = 258 total (was 256) +1 mvnsite 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 6s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 55s the patch passed       Other Tests +1 unit 8m 51s hadoop-common in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 83m 0s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910803/HADOOP-15230.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux b4cdbc17ff0c 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 0b489e5 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14140/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14140/testReport/ Max. process+thread count 1717 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14140/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 22s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 17m 50s trunk passed
            +1 compile 16m 0s trunk passed
            +1 checkstyle 0m 40s trunk passed
            +1 mvnsite 1m 9s trunk passed
            +1 shadedclient 12m 21s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 28s trunk passed
            +1 javadoc 0m 53s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 44s the patch passed
            +1 compile 13m 30s the patch passed
            +1 javac 13m 30s the patch passed
            -0 checkstyle 0m 48s hadoop-common-project/hadoop-common: The patch generated 10 new + 126 unchanged - 130 fixed = 136 total (was 256)
            +1 mvnsite 1m 15s the patch passed
            -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
            +1 shadedclient 10m 29s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 35s the patch passed
            +1 javadoc 0m 56s the patch passed
                  Other Tests
            +1 unit 8m 48s hadoop-common in the patch passed.
            +1 asflicense 0m 38s The patch does not generate ASF License warnings.
            89m 5s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910851/HADOOP-15230.004.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux b1c2d81b99a3 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 8013475
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/artifact/out/whitespace-eol.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/testReport/
            Max. process+thread count 1352 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 17m 50s trunk passed +1 compile 16m 0s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 9s trunk passed +1 shadedclient 12m 21s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 28s trunk passed +1 javadoc 0m 53s trunk passed       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 13m 30s the patch passed +1 javac 13m 30s the patch passed -0 checkstyle 0m 48s hadoop-common-project/hadoop-common: The patch generated 10 new + 126 unchanged - 130 fixed = 136 total (was 256) +1 mvnsite 1m 15s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedclient 10m 29s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 56s the patch passed       Other Tests +1 unit 8m 48s hadoop-common in the patch passed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 89m 5s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910851/HADOOP-15230.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux b1c2d81b99a3 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 8013475 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/artifact/out/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/testReport/ Max. process+thread count 1352 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14144/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 16m 44s trunk passed
            +1 compile 13m 30s trunk passed
            +1 checkstyle 0m 40s trunk passed
            +1 mvnsite 1m 5s trunk passed
            +1 shadedclient 11m 58s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 26s trunk passed
            +1 javadoc 0m 55s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 44s the patch passed
            +1 compile 12m 17s the patch passed
            +1 javac 12m 17s the patch passed
            -0 checkstyle 0m 37s hadoop-common-project/hadoop-common: The patch generated 9 new + 3 unchanged - 253 fixed = 12 total (was 256)
            +1 mvnsite 1m 3s the patch passed
            -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
            +1 shadedclient 10m 21s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 39s the patch passed
            +1 javadoc 0m 53s the patch passed
                  Other Tests
            +1 unit 9m 16s hadoop-common in the patch passed.
            +1 asflicense 0m 32s The patch does not generate ASF License warnings.
            83m 40s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910868/HADOOP-15230.005.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 3d5952eaa9e2 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 8013475
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/artifact/out/whitespace-eol.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/testReport/
            Max. process+thread count 1675 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 16m 44s trunk passed +1 compile 13m 30s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 5s trunk passed +1 shadedclient 11m 58s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 26s trunk passed +1 javadoc 0m 55s trunk passed       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 12m 17s the patch passed +1 javac 12m 17s the patch passed -0 checkstyle 0m 37s hadoop-common-project/hadoop-common: The patch generated 9 new + 3 unchanged - 253 fixed = 12 total (was 256) +1 mvnsite 1m 3s the patch passed -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedclient 10m 21s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 53s the patch passed       Other Tests +1 unit 9m 16s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 83m 40s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910868/HADOOP-15230.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 3d5952eaa9e2 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 8013475 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/artifact/out/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/testReport/ Max. process+thread count 1675 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14146/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 16s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 16m 55s trunk passed
            +1 compile 13m 19s trunk passed
            +1 checkstyle 0m 40s trunk passed
            +1 mvnsite 1m 4s trunk passed
            +1 shadedclient 12m 2s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 28s trunk passed
            +1 javadoc 0m 53s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 45s the patch passed
            +1 compile 12m 15s the patch passed
            +1 javac 12m 15s the patch passed
            -0 checkstyle 0m 37s hadoop-common-project/hadoop-common: The patch generated 9 new + 3 unchanged - 253 fixed = 12 total (was 256)
            +1 mvnsite 1m 2s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 10m 10s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 57s the patch passed
            +1 javadoc 0m 56s the patch passed
                  Other Tests
            +1 unit 9m 23s hadoop-common in the patch passed.
            +1 asflicense 0m 33s The patch does not generate ASF License warnings.
            83m 58s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910882/HADOOP-15230.006.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 146f118dc091 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / a1e05e0
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14148/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14148/testReport/
            Max. process+thread count 1649 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14148/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 16m 55s trunk passed +1 compile 13m 19s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 4s trunk passed +1 shadedclient 12m 2s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 28s trunk passed +1 javadoc 0m 53s trunk passed       Patch Compile Tests +1 mvninstall 0m 45s the patch passed +1 compile 12m 15s the patch passed +1 javac 12m 15s the patch passed -0 checkstyle 0m 37s hadoop-common-project/hadoop-common: The patch generated 9 new + 3 unchanged - 253 fixed = 12 total (was 256) +1 mvnsite 1m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 10s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 56s the patch passed       Other Tests +1 unit 9m 23s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 83m 58s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910882/HADOOP-15230.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 146f118dc091 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / a1e05e0 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/14148/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14148/testReport/ Max. process+thread count 1649 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14148/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            genericqa genericqa added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 18s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 18m 4s trunk passed
            +1 compile 15m 18s trunk passed
            +1 checkstyle 0m 41s trunk passed
            +1 mvnsite 1m 6s trunk passed
            +1 shadedclient 12m 30s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 28s trunk passed
            +1 javadoc 0m 54s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 44s the patch passed
            +1 compile 13m 15s the patch passed
            +1 javac 13m 15s the patch passed
            +1 checkstyle 0m 38s hadoop-common-project/hadoop-common: The patch generated 0 new + 2 unchanged - 254 fixed = 2 total (was 256)
            +1 mvnsite 1m 5s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 10m 6s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 36s the patch passed
            +1 javadoc 0m 54s the patch passed
                  Other Tests
            +1 unit 8m 16s hadoop-common in the patch passed.
            +1 asflicense 0m 33s The patch does not generate ASF License warnings.
            87m 5s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 9af0b7bd73a4 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 82f029f
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14157/testReport/
            Max. process+thread count 1356 (vs. ulimit of 5500)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14157/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 18m 4s trunk passed +1 compile 15m 18s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 6s trunk passed +1 shadedclient 12m 30s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 28s trunk passed +1 javadoc 0m 54s trunk passed       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 13m 15s the patch passed +1 javac 13m 15s the patch passed +1 checkstyle 0m 38s hadoop-common-project/hadoop-common: The patch generated 0 new + 2 unchanged - 254 fixed = 2 total (was 256) +1 mvnsite 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 6s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 54s the patch passed       Other Tests +1 unit 8m 16s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 87m 5s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 9af0b7bd73a4 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 82f029f maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/14157/testReport/ Max. process+thread count 1356 (vs. ulimit of 5500) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/14157/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            githubbot ASF GitHub Bot added a comment -

            Github user howardyoo commented on the issue:

            https://github.com/apache/hadoop/pull/340

            Now, the code is ready to be merged. Patch passed all the tests and without any serious conflicts. I hope the apache hadoop team would review this simple fix and merge it into the trunk branch soon.

            githubbot ASF GitHub Bot added a comment - Github user howardyoo commented on the issue: https://github.com/apache/hadoop/pull/340 Now, the code is ready to be merged. Patch passed all the tests and without any serious conflicts. I hope the apache hadoop team would review this simple fix and merge it into the trunk branch soon.
            githubbot ASF GitHub Bot added a comment -

            Github user bak12 commented on the issue:

            https://github.com/apache/hadoop/pull/340

            😁

            githubbot ASF GitHub Bot added a comment - Github user bak12 commented on the issue: https://github.com/apache/hadoop/pull/340 😁
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 25m 27s trunk passed
            +1 compile 18m 34s trunk passed
            +1 checkstyle 0m 54s trunk passed
            +1 mvnsite 1m 17s trunk passed
            +1 shadedclient 14m 33s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 44s trunk passed
            +1 javadoc 1m 0s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 59s the patch passed
            +1 compile 15m 20s the patch passed
            -1 javac 15m 20s root generated 5 new + 1485 unchanged - 5 fixed = 1490 total (was 1490)
            +1 checkstyle 0m 52s hadoop-common-project/hadoop-common: The patch generated 0 new + 2 unchanged - 254 fixed = 2 total (was 256)
            +1 mvnsite 1m 10s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 12m 7s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 43s the patch passed
            +1 javadoc 1m 0s the patch passed
                  Other Tests
            +1 unit 9m 1s hadoop-common in the patch passed.
            +1 asflicense 0m 37s The patch does not generate ASF License warnings.
            106m 11s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux d446ce18da98 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / f659485
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_181
            findbugs v3.1.0-RC1
            javac https://builds.apache.org/job/PreCommit-HADOOP-Build/15684/artifact/out/diff-compile-javac-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/15684/testReport/
            Max. process+thread count 1382 (vs. ulimit of 10000)
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/15684/console
            Powered by Apache Yetus 0.8.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 25m 27s trunk passed +1 compile 18m 34s trunk passed +1 checkstyle 0m 54s trunk passed +1 mvnsite 1m 17s trunk passed +1 shadedclient 14m 33s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 44s trunk passed +1 javadoc 1m 0s trunk passed       Patch Compile Tests +1 mvninstall 0m 59s the patch passed +1 compile 15m 20s the patch passed -1 javac 15m 20s root generated 5 new + 1485 unchanged - 5 fixed = 1490 total (was 1490) +1 checkstyle 0m 52s hadoop-common-project/hadoop-common: The patch generated 0 new + 2 unchanged - 254 fixed = 2 total (was 256) +1 mvnsite 1m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 12m 7s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 43s the patch passed +1 javadoc 1m 0s the patch passed       Other Tests +1 unit 9m 1s hadoop-common in the patch passed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 106m 11s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux d446ce18da98 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / f659485 maven version: Apache Maven 3.3.9 Default Java 1.8.0_181 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/15684/artifact/out/diff-compile-javac-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/15684/testReport/ Max. process+thread count 1382 (vs. ulimit of 10000) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/15684/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 0s Docker mode activated.
            -1 patch 0m 9s HADOOP-15230 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 9s HADOOP-15230 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/16490/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            hadoopci Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Logfile Comment
            0 reexec 0m 0s Docker mode activated.
            -1 patch 0m 11s HADOOP-15230 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



            Subsystem Report/Notes
            JIRA Issue HADOOP-15230
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch
            Console output https://ci-hadoop.apache.org/job/PreCommit-HADOOP-Build/153/console
            versions git=2.17.1
            Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

            This message was automatically generated.

            hadoopci Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Logfile Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 11s HADOOP-15230 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-15230 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910948/HADOOP-15230.007.patch Console output https://ci-hadoop.apache.org/job/PreCommit-HADOOP-Build/153/console versions git=2.17.1 Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org This message was automatically generated.

            People

              howardyoo Howard Yoo
              howardyoo Howard Yoo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h