Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-1470

Rework FSInputChecker and FSOutputSummer to support checksum code sharing between ChecksumFileSystem and block level crc dfs

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.12.3
    • 0.14.0
    • fs
    • None

    Description

      Comment from Doug in HADOOP-1134:
      I'd prefer it if the CRC code could be shared with CheckSumFileSystem. In particular, it seems to me that FSInputChecker and FSOutputSummer could be extended to support pluggable sources and sinks for checksums, respectively, and DFSDataInputStream and DFSDataOutputStream could use these. Advantages of this are: (a) single implementation of checksum logic to debug and maintain; (b) keeps checksumming as close to possible to data generation and use. This patch computes checksums after data has been buffered, and validates them before it is buffered. We sometimes use large buffers and would like to guard against in-memory errors. The current checksum code catches a lot of such errors. So we should compute checksums after minimal buffering (just bytesPerChecksum, ideally) and validate them at the last possible moment (e.g., through the use of a small final buffer with a larger buffer behind it). I do not think this will significantly affect performance, and data integrity is a high priority.

      Attachments

        1. InputChecker-01.java
          3 kB
          Raghu Angadi
        2. GenericChecksum4.patch
          69 kB
          Hairong Kuang
        3. GenericChecksum3.patch
          69 kB
          Hairong Kuang
        4. GenericChecksum2.patch
          64 kB
          Hairong Kuang
        5. GenericChecksum1.patch
          63 kB
          Hairong Kuang
        6. GenericChecksum.patch
          64 kB
          Hairong Kuang
        7. genericChecksum.patch
          7 kB
          Hairong Kuang

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hairong Hairong Kuang
            hairong Hairong Kuang
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment