Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14702

Fix formatting issue and regression caused by conversion from APT to Markdown

    Details

      Description

      There are some gaps between java sources and site documentations, 3.0.0 does the work but still can do some improvements.

      1. HADOOP-14702.001.patch
        6 kB
        Doris Gu
      2. HADOOP-14702-branch-2.001.patch
        8 kB
        Doris Gu
      3. HADOOP-14702.002.patch
        6 kB
        Doris Gu
      4. HADOOP-14702-branch-2.002.patch
        8 kB
        Doris Gu

        Issue Links

          Activity

          Hide
          doris Doris Gu added a comment -

          Happen to meet some missed metrics at web site of branch-2, then figure out there was a migration of web documentation from apt to markdown, and some issues during migration time were missed to be merged.

          Show
          doris Doris Gu added a comment - Happen to meet some missed metrics at web site of branch-2, then figure out there was a migration of web documentation from apt to markdown, and some issues during migration time were missed to be merged.
          Hide
          doris Doris Gu added a comment -

          Masatake Iwasaki, sorry to bother.

          Show
          doris Doris Gu added a comment - Masatake Iwasaki , sorry to bother.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
                branch-2 Compile Tests
          +1 mvninstall 6m 58s branch-2 passed
          +1 mvnsite 0m 59s branch-2 passed
                Patch Compile Tests
          +1 mvnsite 0m 56s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
                Other Tests
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          9m 54s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14702
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879605/HADOOP-14702-branch-2.001.patch
          Optional Tests asflicense mvnsite
          uname Linux ab003317c952 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 72bde1d
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12910/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       branch-2 Compile Tests +1 mvninstall 6m 58s branch-2 passed +1 mvnsite 0m 59s branch-2 passed       Patch Compile Tests +1 mvnsite 0m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 asflicense 0m 17s The patch does not generate ASF License warnings. 9m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14702 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879605/HADOOP-14702-branch-2.001.patch Optional Tests asflicense mvnsite uname Linux ab003317c952 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 72bde1d modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12910/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for reporting this, Doris Gu.

          The patch looks good. Since it fixes just formatting (and regressions in branch-2), I will update the issue title and commit this.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for reporting this, Doris Gu . The patch looks good. Since it fixes just formatting (and regressions in branch-2), I will update the issue title and commit this.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Just one nit. The line below has invalid formatting. Could you replace >> and <<< with backquote?

          +Example: The property name of blocked access control list for `security.client.protocol.acl>> will be <<<security.client.protocol.acl.blocked`
          
          Show
          iwasakims Masatake Iwasaki added a comment - Just one nit. The line below has invalid formatting. Could you replace >> and <<< with backquote? +Example: The property name of blocked access control list for `security.client.protocol.acl>> will be <<<security.client.protocol.acl.blocked`
          Hide
          doris Doris Gu added a comment -

          Nice catch, I've already updated patches, please check, Masatake Iwasaki

          Show
          doris Doris Gu added a comment - Nice catch, I've already updated patches, please check, Masatake Iwasaki
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
                trunk Compile Tests
          +1 mvninstall 13m 49s trunk passed
          +1 mvnsite 1m 21s trunk passed
                Patch Compile Tests
          +1 mvnsite 1m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
                Other Tests
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          17m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14702
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879948/HADOOP-14702.002.patch
          Optional Tests asflicense mvnsite
          uname Linux aead546bc3fa 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6814324
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12923/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests +1 mvninstall 13m 49s trunk passed +1 mvnsite 1m 21s trunk passed       Patch Compile Tests +1 mvnsite 1m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 asflicense 0m 14s The patch does not generate ASF License warnings. 17m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14702 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879948/HADOOP-14702.002.patch Optional Tests asflicense mvnsite uname Linux aead546bc3fa 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6814324 modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12923/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          +1, committing this.

          Show
          iwasakims Masatake Iwasaki added a comment - +1, committing this.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12100 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12100/)
          HADOOP-14702. Fix formatting issue and regression caused by conversion (iwasakims: rev 3a0b84d9c994f9a634b32903e5c1876c44f8c16e)

          • (edit) hadoop-common-project/hadoop-common/src/site/markdown/ServiceLevelAuth.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12100 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12100/ ) HADOOP-14702 . Fix formatting issue and regression caused by conversion (iwasakims: rev 3a0b84d9c994f9a634b32903e5c1876c44f8c16e) (edit) hadoop-common-project/hadoop-common/src/site/markdown/ServiceLevelAuth.md
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed to trunk, branch-2, branch-2.8 and branch-2.7. Thanks for the contribution, Doris Gu.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed to trunk, branch-2, branch-2.8 and branch-2.7. Thanks for the contribution, Doris Gu .

            People

            • Assignee:
              doris Doris Gu
              Reporter:
              doris Doris Gu
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development