Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14701

Configuration can log misleading warnings about an attempt to override final parameter

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: conf
    • Labels:
      None

      Description

      The class Configuration (in hadoop-common-project) is used to hold configuration properties.

      The method loadResources() is used to load properties from a list of default resources into a parameter called “properties” (which happens to always be the field called “properties”).

      This is done by calling the method loadResource() which is used to load properties from a single resource into a parameter called “properties” (which happens to always be the field called “properties”).

      This is done by calling loadProperty() which is used to load a single property into a parameter called “properties” (which is sometimes, but not always, the field called “properties”).

      In loadProperty() there is some logic for dealing with properties that are marked as final.
      (1) a final property is not set into the “properties” parameter.
      (2) a warning is printed for a final property if the value of the property with the same name in the “properties” parameter is not equal to the new value, and the property name is in the finalParameters field.

      When loadResource() is reading properties from a stream it creates a temporary Properties object that it populates by calling loadProperty(). This is the case where loadProperty() has a parameter called “properties” which is not the same as the field called “properties”).
      When loadProperty() is called on a final property then because of (1) it is not set into the “properties” parameter. But sometimes the property name is already in the finalParameters field and now (2) the warning is triggered because the property is not present in the “properties” parameter (although it IS present in the “properties” field). The warning is misleading and confusing.

      Possible Fix

      One way of looking at the problem is that loadProperty is using the finalParameters field in combination with the “properties” parameter. Change the code to only generate a warning for a final property if the value of the property with the same name in the “properties” field is not equal to the new value, and the property name is in the finalParameters field.

      I’ve made a patch containing this tiny change.

      Note that I have done very minimal testing of this fix

      Example warning:

      2017-07-25 12:14:24,639 WARN org.apache.hadoop.conf.Configuration: [HiveServer2-Background-Pool: Thread-77]: hdfs://asherman-cdh6-subset-parcel-1.gce.cloudera.com:8020/user/hive/.staging/job_1501008923167_0001/job.xml:an attempt to override final parameter: mapreduce.job.end-notification.max.retry.interval; Ignoring.

      1. HADOOP-14701.1.patch
        1 kB
        Andrew Sherman
      2. HADOOP-14701.2.patch
        6 kB
        Andrew Sherman
      3. HADOOP-14701.3.patch
        6 kB
        Andrew Sherman
      4. HADOOP-14701.4.patch
        10 kB
        Andrew Sherman

        Activity

        Hide
        asherman Andrew Sherman added a comment -

        Thanks Andrew for your help and for the commit

        Show
        asherman Andrew Sherman added a comment - Thanks Andrew for your help and for the commit
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12094 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12094/)
        HADOOP-14701. Configuration can log misleading warnings about an attempt (wang: rev a11c230236036317a6c12deeca401e3ae8dce698)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12094 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12094/ ) HADOOP-14701 . Configuration can log misleading warnings about an attempt (wang: rev a11c230236036317a6c12deeca401e3ae8dce698) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks again for the contribution Andrew! I've committed this to trunk and branch-2.

        Show
        andrew.wang Andrew Wang added a comment - Thanks again for the contribution Andrew! I've committed this to trunk and branch-2.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 14m 24s trunk passed
        +1 compile 14m 16s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 38s trunk passed
        +1 findbugs 1m 33s trunk passed
        +1 javadoc 0m 52s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 49s the patch passed
        +1 compile 11m 43s the patch passed
        +1 javac 11m 43s the patch passed
        -0 checkstyle 0m 38s hadoop-common-project/hadoop-common: The patch generated 3 new + 262 unchanged - 0 fixed = 265 total (was 262)
        +1 mvnsite 1m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 40s the patch passed
        +1 javadoc 0m 51s the patch passed
              Other Tests
        +1 unit 8m 0s hadoop-common in the patch passed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        61m 2s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14701
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879906/HADOOP-14701.4.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 514bae015701 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 778d4ed
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12921/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12921/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12921/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 24s trunk passed +1 compile 14m 16s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 38s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 52s trunk passed       Patch Compile Tests +1 mvninstall 0m 49s the patch passed +1 compile 11m 43s the patch passed +1 javac 11m 43s the patch passed -0 checkstyle 0m 38s hadoop-common-project/hadoop-common: The patch generated 3 new + 262 unchanged - 0 fixed = 265 total (was 262) +1 mvnsite 1m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 40s the patch passed +1 javadoc 0m 51s the patch passed       Other Tests +1 unit 8m 0s hadoop-common in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 61m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14701 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879906/HADOOP-14701.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 514bae015701 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 778d4ed Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12921/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12921/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12921/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the quick rev! LGTM, though let's wait for the Jenkins report before committing.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the quick rev! LGTM, though let's wait for the Jenkins report before committing.
        Hide
        asherman Andrew Sherman added a comment -

        Thanks Andrew Wang for the question. Your intuition was right that the case where a property is declared twice in the same file does require some extra work. In the new patch I added 2 new tests (for the case where the same property occurs twice, and where a property has differing values). I changed the "fix" to warn if the new value differs from a non-null value in either the the “properties” field or the "properties" parameter. This does mean the fix is no longer a one line change, but it is better.
        This code is in the new patch (#4).

        Show
        asherman Andrew Sherman added a comment - Thanks Andrew Wang for the question. Your intuition was right that the case where a property is declared twice in the same file does require some extra work. In the new patch I added 2 new tests (for the case where the same property occurs twice, and where a property has differing values). I changed the "fix" to warn if the new value differs from a non-null value in either the the “properties” field or the "properties" parameter. This does mean the fix is no longer a one line change, but it is better. This code is in the new patch (#4).
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for filing this JIRA and providing a patch Andrew Sherman! Your detailed explanation made it quite clear, the scoping of the field and parameter do not match.

        One question, does it log the WARN when a property is declared multiple times in the same file? Wasn't clear when this.properties gets updated. A test for this would be nice too.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for filing this JIRA and providing a patch Andrew Sherman ! Your detailed explanation made it quite clear, the scoping of the field and parameter do not match. One question, does it log the WARN when a property is declared multiple times in the same file? Wasn't clear when this.properties gets updated. A test for this would be nice too.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 14m 22s trunk passed
        +1 compile 13m 33s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 50s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 38s the patch passed
        +1 compile 10m 18s the patch passed
        +1 javac 10m 18s the patch passed
        +1 checkstyle 0m 39s the patch passed
        +1 mvnsite 1m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 49s the patch passed
              Other Tests
        -1 unit 8m 1s hadoop-common in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        58m 10s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14701
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879743/HADOOP-14701.3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 18ce03249b7d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ea56812
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12907/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12907/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 22s trunk passed +1 compile 13m 33s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 27s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 50s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 10m 18s the patch passed +1 javac 10m 18s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 49s the patch passed       Other Tests -1 unit 8m 1s hadoop-common in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 58m 10s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14701 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879743/HADOOP-14701.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18ce03249b7d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea56812 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12907/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12907/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 15m 2s trunk passed
        +1 compile 14m 29s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 51s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 39s the patch passed
        +1 compile 10m 9s the patch passed
        +1 javac 10m 9s the patch passed
        -0 checkstyle 0m 38s hadoop-common-project/hadoop-common: The patch generated 9 new + 262 unchanged - 0 fixed = 271 total (was 262)
        +1 mvnsite 1m 27s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 50s the patch passed
              Other Tests
        -1 unit 7m 57s hadoop-common in the patch failed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        59m 35s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14701
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879732/HADOOP-14701.2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9dae0feb2d0a 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2be9412
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 2s trunk passed +1 compile 14m 29s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 27s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 51s trunk passed       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 10m 9s the patch passed +1 javac 10m 9s the patch passed -0 checkstyle 0m 38s hadoop-common-project/hadoop-common: The patch generated 9 new + 262 unchanged - 0 fixed = 271 total (was 262) +1 mvnsite 1m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests -1 unit 7m 57s hadoop-common in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 59m 35s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14701 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879732/HADOOP-14701.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9dae0feb2d0a 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2be9412 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12906/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 0s trunk passed
        +1 compile 14m 39s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 30s trunk passed
        +1 findbugs 1m 26s trunk passed
        +1 javadoc 0m 51s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 41s the patch passed
        +1 compile 10m 55s the patch passed
        +1 javac 10m 55s the patch passed
        +1 checkstyle 0m 36s the patch passed
        +1 mvnsite 1m 28s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 50s the patch passed
              Other Tests
        +1 unit 9m 4s hadoop-common in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        60m 42s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14701
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879450/HADOOP-14701.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3f1974234343 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3e23415
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12902/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12902/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 0s trunk passed +1 compile 14m 39s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 30s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 51s trunk passed       Patch Compile Tests +1 mvninstall 0m 41s the patch passed +1 compile 10m 55s the patch passed +1 javac 10m 55s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 28s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests +1 unit 9m 4s hadoop-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 60m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14701 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879450/HADOOP-14701.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3f1974234343 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3e23415 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12902/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12902/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            asherman Andrew Sherman
            Reporter:
            asherman Andrew Sherman
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development