Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.1
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: common, conf, fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      According to core-default.xml the default value of fs.df.interval = 60 sec. But the implementation of DF substitutes 3 sec instead. The problem is that DF uses outdated constant DF.DF_INTERVAL_DEFAULT instead of the correct one CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT.

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 from me also. Committed this to trunk and branch-2. Thanks for reporting this Konstantin and thanks for the fix xiangguang.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 from me also. Committed this to trunk and branch-2. Thanks for reporting this Konstantin and thanks for the fix xiangguang.
        Hide
        shv Konstantin Shvachko added a comment -

        +1 Looks good.

        Show
        shv Konstantin Shvachko added a comment - +1 Looks good.
        Hide
        zhengxg3 Sherwood Zheng added a comment -

        Konstantin Shvachko Could you take a look when you have a chance?

        Show
        zhengxg3 Sherwood Zheng added a comment - Konstantin Shvachko Could you take a look when you have a chance?
        Hide
        zhengxg3 Sherwood Zheng added a comment - - edited

        The manual steps I did to verify:
        1. compile and run the unit test towards hadoop common module. When I run the test, there were 9 test failure and 1 test error. But I have verified that those failure and errors existed in hadoop trunk before I made any changes, and none of test failure/error was related to this patch

        2. Run local debugger on MiniHadoopClusterManager Class to test if DF load the correct default interval value(fs.df.interval was removed from core-default.xml when testing so that DF constructor was forced to read value from Constant CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of from core-default.xml

        Show
        zhengxg3 Sherwood Zheng added a comment - - edited The manual steps I did to verify: 1. compile and run the unit test towards hadoop common module. When I run the test, there were 9 test failure and 1 test error. But I have verified that those failure and errors existed in hadoop trunk before I made any changes, and none of test failure/error was related to this patch 2. Run local debugger on MiniHadoopClusterManager Class to test if DF load the correct default interval value(fs.df.interval was removed from core-default.xml when testing so that DF constructor was forced to read value from Constant CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of from core-default.xml
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 18m 16s trunk passed
        +1 compile 19m 9s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 1m 50s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 1m 3s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 0s the patch passed
        +1 compile 13m 42s the patch passed
        +1 javac 13m 42s the patch passed
        +1 checkstyle 0m 42s hadoop-common-project/hadoop-common: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
        +1 mvnsite 1m 41s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 59s the patch passed
              Other Tests
        +1 unit 9m 25s hadoop-common in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        75m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14676
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879434/HADOOP-14676.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0323f0016078 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 713349a
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12889/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12889/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 18m 16s trunk passed +1 compile 19m 9s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 50s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 3s trunk passed       Patch Compile Tests +1 mvninstall 1m 0s the patch passed +1 compile 13m 42s the patch passed +1 javac 13m 42s the patch passed +1 checkstyle 0m 42s hadoop-common-project/hadoop-common: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) +1 mvnsite 1m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 59s the patch passed       Other Tests +1 unit 9m 25s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 75m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14676 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879434/HADOOP-14676.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0323f0016078 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 713349a Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12889/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12889/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 1s trunk passed
        +1 compile 14m 55s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 50s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 38s the patch passed
        +1 compile 11m 13s the patch passed
        +1 javac 11m 13s the patch passed
        +1 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
        +1 mvnsite 1m 27s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 53s the patch passed
              Other Tests
        +1 unit 7m 36s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        59m 53s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14676
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879404/HADOOP-14676.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f081ca315932 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 746189a
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/artifact/patchprocess/whitespace-eol.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 1s trunk passed +1 compile 14m 55s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 27s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 50s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 11m 13s the patch passed +1 javac 11m 13s the patch passed +1 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) +1 mvnsite 1m 27s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 32s the patch passed +1 javadoc 0m 53s the patch passed       Other Tests +1 unit 7m 36s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 59m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14676 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879404/HADOOP-14676.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f081ca315932 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 746189a Default Java 1.8.0_131 findbugs v3.1.0-RC1 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 15m 40s trunk passed
        +1 compile 15m 50s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 50s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 38s the patch passed
        +1 compile 10m 13s the patch passed
        +1 javac 10m 13s the patch passed
        -0 checkstyle 0m 35s hadoop-common-project/hadoop-common: The patch generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5)
        +1 mvnsite 1m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 49s the patch passed
              Other Tests
        -1 unit 7m 58s hadoop-common in the patch failed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        61m 32s



        Reason Tests
        Failed junit tests hadoop.security.TestRaceWhenRelogin
          hadoop.security.TestKDiag



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14676
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879382/HADOOP-14676.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 27c090312e4b 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9ea01fd
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 40s trunk passed +1 compile 15m 50s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 27s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 50s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 10m 13s the patch passed +1 javac 10m 13s the patch passed -0 checkstyle 0m 35s hadoop-common-project/hadoop-common: The patch generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5) +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 49s the patch passed       Other Tests -1 unit 7m 58s hadoop-common in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 61m 32s Reason Tests Failed junit tests hadoop.security.TestRaceWhenRelogin   hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14676 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879382/HADOOP-14676.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 27c090312e4b 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9ea01fd Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xkrogen Erik Krogen added a comment - - edited

        Hey Sherwood Zheng, thanks for working on this. A few things:

        • When you upload the patch you should put a version name in it, e.g. HADOOP-14676.000.patch. This helps us to track the revisions of the patch as we go through the review-update cycle. Also, I think it might be required for Jenkins to run the precommit build against your patch.
        • I don't think DF.DF_INTERVAL_DEFAULT is used anywhere anymore, can you confirm this and if so then delete it altogether?
        • Please don't use wildcard (*) imports.
        • Keep line length below 80 characters to pass checkstyle.
        Show
        xkrogen Erik Krogen added a comment - - edited Hey Sherwood Zheng , thanks for working on this. A few things: When you upload the patch you should put a version name in it, e.g. HADOOP-14676 .000.patch. This helps us to track the revisions of the patch as we go through the review-update cycle. Also, I think it might be required for Jenkins to run the precommit build against your patch. I don't think DF.DF_INTERVAL_DEFAULT is used anywhere anymore, can you confirm this and if so then delete it altogether? Please don't use wildcard ( * ) imports. Keep line length below 80 characters to pass checkstyle.
        Hide
        zhengxg3 Sherwood Zheng added a comment -

        Please review the code, I modified the DF.java to use the CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of outdated DF.DF_INTERVAL_DEFAULT

        Show
        zhengxg3 Sherwood Zheng added a comment - Please review the code, I modified the DF.java to use the CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of outdated DF.DF_INTERVAL_DEFAULT
        Hide
        shv Konstantin Shvachko added a comment -

        I traced it all the way to 2.6.1.
        DataNodes on our cluster were using too much system time and it was traced to frequent statfs. Thanks Ganesh Ananthanarayanan for digging into this.
        The workaround is to actually specify the default value in core-site.xml, then it will not use the fake default. But we should fix it.

        Show
        shv Konstantin Shvachko added a comment - I traced it all the way to 2.6.1. DataNodes on our cluster were using too much system time and it was traced to frequent statfs . Thanks Ganesh Ananthanarayanan for digging into this. The workaround is to actually specify the default value in core-site.xml , then it will not use the fake default. But we should fix it.

          People

          • Assignee:
            zhengxg3 Sherwood Zheng
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development