Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14673

Remove leftover hadoop_xml_escape from functions

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 3.0.0-beta1
        • Fix Version/s: 3.0.0-beta1
        • Component/s: scripts
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          This function is no longer needed, so let's purge it.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            aw Allen Wittenauer added a comment -

            hadoop_sed_escape as well.

            Show
            aw Allen Wittenauer added a comment - hadoop_sed_escape as well.
            Hide
            Permalink
            ajayydv Ajay Kumar added a comment - - edited

            Allen Wittenauer, Removed functions from hadoop-functions.sh and related test cases . Could you please review the patch?

            Show
            ajayydv Ajay Kumar added a comment - - edited Allen Wittenauer , Removed functions from hadoop-functions.sh and related test cases . Could you please review the patch?
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 16s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 19m 39s trunk passed
            +1 mvnsite 1m 55s trunk passed
                  Patch Compile Tests
            +1 mvnsite 1m 43s the patch passed
            +1 shellcheck 0m 4s There were no new shellcheck issues.
            +1 shelldocs 0m 10s There were no new shelldocs issues.
            +1 whitespace 0m 0s The patch has no whitespace issues.
                  Other Tests
            +1 unit 2m 30s hadoop-common in the patch passed.
            +1 asflicense 0m 22s The patch does not generate ASF License warnings.
            27m 9s



            Subsystem Report/Notes
            Docker Image:yetus/hadoop:14b5c93
            JIRA Issue HADOOP-14673
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879767/HADOOP-14673.01.patch
            Optional Tests asflicense mvnsite unit shellcheck shelldocs
            uname Linux 9a296a684321 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
            git revision trunk / a4aa1cb
            shellcheck v0.4.6
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12909/testReport/
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12909/console
            Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 19m 39s trunk passed +1 mvnsite 1m 55s trunk passed       Patch Compile Tests +1 mvnsite 1m 43s the patch passed +1 shellcheck 0m 4s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 2m 30s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 27m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14673 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879767/HADOOP-14673.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 9a296a684321 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a4aa1cb shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12909/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12909/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            Hide
            Permalink
            arpitagarwal Arpit Agarwal added a comment -

            Committed this after checking there are no references to the removed functions and running shell tests locally.

            Show
            arpitagarwal Arpit Agarwal added a comment - Committed this after checking there are no references to the removed functions and running shell tests locally.
            Hide
            Permalink
            arpitagarwal Arpit Agarwal added a comment -

            Thanks for the contribution Ajay Kumar.

            Show
            arpitagarwal Arpit Agarwal added a comment - Thanks for the contribution Ajay Kumar .
            Hide
            Permalink
            ajayydv Ajay Kumar added a comment -

            Arpit Agarwal,Allen Wittenauer Thanks for review and commit.

            Show
            ajayydv Ajay Kumar added a comment - Arpit Agarwal , Allen Wittenauer Thanks for review and commit.

              People

              • Assignee:
                ajayydv Ajay Kumar
                Reporter:
                aw Allen Wittenauer
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development