Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
3.0.0-beta1
-
None
-
None
-
Reviewed
Description
Update the dependency
joda-time:joda-time:2.9.4
to the latest (2.9.9).
Attachments
Attachments
- HADOOP-14653.002.patch
- 1 kB
- Ray Chiang
- HADOOP-14653.001.patch
- 0.5 kB
- Ray Chiang
Activity
Hadoop QA
added a comment -
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 16s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
trunk Compile Tests | |||
+1 | mvninstall | 15m 7s | trunk passed |
+1 | compile | 0m 9s | trunk passed |
+1 | mvnsite | 0m 12s | trunk passed |
+1 | javadoc | 0m 10s | trunk passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 7s | the patch passed |
+1 | compile | 0m 7s | the patch passed |
+1 | javac | 0m 7s | the patch passed |
+1 | mvnsite | 0m 8s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | xml | 0m 1s | The patch has no ill-formed XML file. |
+1 | javadoc | 0m 7s | the patch passed |
Other Tests | |||
+1 | unit | 0m 6s | hadoop-project in the patch passed. |
+1 | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
17m 31s |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:14b5c93 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12878847/HADOOP-14653.001.patch |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml |
uname | Linux e85111c9c8c9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 2d105a2 |
Default Java | 1.8.0_144 |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/13070/testReport/ |
modules | C: hadoop-project U: hadoop-project |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/13070/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Hadoop QA
added a comment -
-1 overall
Vote
Subsystem
Runtime
Comment
0
reexec
0m 16s
Docker mode activated.
Prechecks
+1
@author
0m 0s
The patch does not contain any @author tags.
-1
test4tests
0m 0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
trunk Compile Tests
+1
mvninstall
15m 7s
trunk passed
+1
compile
0m 9s
trunk passed
+1
mvnsite
0m 12s
trunk passed
+1
javadoc
0m 10s
trunk passed
Patch Compile Tests
+1
mvninstall
0m 7s
the patch passed
+1
compile
0m 7s
the patch passed
+1
javac
0m 7s
the patch passed
+1
mvnsite
0m 8s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
xml
0m 1s
The patch has no ill-formed XML file.
+1
javadoc
0m 7s
the patch passed
Other Tests
+1
unit
0m 6s
hadoop-project in the patch passed.
+1
asflicense
0m 21s
The patch does not generate ASF License warnings.
17m 31s
Subsystem
Report/Notes
Docker
Image:yetus/hadoop:14b5c93
JIRA Issue
HADOOP-14653
JIRA Patch URL
https://issues.apache.org/jira/secure/attachment/12878847/HADOOP-14653.001.patch
Optional Tests
asflicense compile javac javadoc mvninstall mvnsite unit xml
uname
Linux e85111c9c8c9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Build tool
maven
Personality
/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision
trunk / 2d105a2
Default Java
1.8.0_144
Test Results
https://builds.apache.org/job/PreCommit-HADOOP-Build/13070/testReport/
modules
C: hadoop-project U: hadoop-project
Console output
https://builds.apache.org/job/PreCommit-HADOOP-Build/13070/console
Powered by
Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org
This message was automatically generated.
Ray Chiang
added a comment -
Comparing against my baseline testing, I'm not seeing any new test failures.
Ray Chiang
added a comment - Comparing against my baseline testing, I'm not seeing any new test failures.
Ray Chiang
added a comment - joda-time is not bundled with Hadoop. L&N check shows nothing.
Andrew Wang
added a comment -
joda-time is bundled in hadoop as part of hadoop-tools, e.g.:
hadoop-3.0.0-alpha3/share/hadoop/tools/lib/joda-time-2.9.4.jar
Nevertheless, LGTM +1, thanks Ray!
Andrew Wang
added a comment - joda-time is bundled in hadoop as part of hadoop-tools, e.g.:
hadoop-3.0.0-alpha3/share/hadoop/tools/lib/joda-time-2.9.4.jar
Nevertheless, LGTM +1, thanks Ray!
Ray Chiang
added a comment -
Thanks for pointing out the jar file inclusion andrew.wang. Adding joda-time's NOTICE to the patch.
Ray Chiang
added a comment - Thanks for pointing out the jar file inclusion andrew.wang . Adding joda-time's NOTICE to the patch.
Hadoop QA
added a comment -
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 23s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
trunk Compile Tests | |||
0 | mvndep | 2m 3s | Maven dependency ordering for branch |
+1 | mvninstall | 16m 46s | trunk passed |
+1 | compile | 19m 23s | trunk passed |
+1 | mvnsite | 9m 35s | trunk passed |
+1 | javadoc | 4m 57s | trunk passed |
Patch Compile Tests | |||
0 | mvndep | 0m 17s | Maven dependency ordering for patch |
+1 | mvninstall | 14m 15s | the patch passed |
+1 | compile | 15m 7s | the patch passed |
+1 | javac | 15m 7s | the patch passed |
+1 | mvnsite | 10m 21s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | xml | 0m 1s | The patch has no ill-formed XML file. |
+1 | javadoc | 4m 57s | the patch passed |
Other Tests | |||
-1 | unit | 14m 27s | root in the patch failed. |
+1 | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
114m 3s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.net.TestDNS |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:71bbb86 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12886489/HADOOP-14653.002.patch |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml |
uname | Linux 096e5cf32092 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / d2d8f66 |
Default Java | 1.8.0_144 |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/13258/artifact/patchprocess/patch-unit-root.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/13258/testReport/ |
modules | C: hadoop-project . U: . |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/13258/console |
Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Hadoop QA
added a comment -
-1 overall
Vote
Subsystem
Runtime
Comment
0
reexec
0m 23s
Docker mode activated.
Prechecks
+1
@author
0m 0s
The patch does not contain any @author tags.
-1
test4tests
0m 0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
trunk Compile Tests
0
mvndep
2m 3s
Maven dependency ordering for branch
+1
mvninstall
16m 46s
trunk passed
+1
compile
19m 23s
trunk passed
+1
mvnsite
9m 35s
trunk passed
+1
javadoc
4m 57s
trunk passed
Patch Compile Tests
0
mvndep
0m 17s
Maven dependency ordering for patch
+1
mvninstall
14m 15s
the patch passed
+1
compile
15m 7s
the patch passed
+1
javac
15m 7s
the patch passed
+1
mvnsite
10m 21s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
xml
0m 1s
The patch has no ill-formed XML file.
+1
javadoc
4m 57s
the patch passed
Other Tests
-1
unit
14m 27s
root in the patch failed.
+1
asflicense
0m 31s
The patch does not generate ASF License warnings.
114m 3s
Reason
Tests
Failed junit tests
hadoop.net.TestDNS
Subsystem
Report/Notes
Docker
Image:yetus/hadoop:71bbb86
JIRA Issue
HADOOP-14653
JIRA Patch URL
https://issues.apache.org/jira/secure/attachment/12886489/HADOOP-14653.002.patch
Optional Tests
asflicense compile javac javadoc mvninstall mvnsite unit xml
uname
Linux 096e5cf32092 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Build tool
maven
Personality
/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision
trunk / d2d8f66
Default Java
1.8.0_144
unit
https://builds.apache.org/job/PreCommit-HADOOP-Build/13258/artifact/patchprocess/patch-unit-root.txt
Test Results
https://builds.apache.org/job/PreCommit-HADOOP-Build/13258/testReport/
modules
C: hadoop-project . U: .
Console output
https://builds.apache.org/job/PreCommit-HADOOP-Build/13258/console
Powered by
Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org
This message was automatically generated.
Ray Chiang
added a comment - Unit test failure looks to be the same as HADOOP-13101 .
Ray Chiang
added a comment - Committed to trunk and branch-3.0.
Thanks andrew.wang for the review!
Hudson
added a comment -
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12848 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12848/)
HADOOP-14653. Update joda-time version to 2.9.9. (rchiang) (rchiang: rev a6432ba5a177ec3d3a95fa79e313a9bbc531a1e7)
- (edit) hadoop-project/pom.xml
- (edit) NOTICE.txt
Hudson
added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12848 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12848/ )
HADOOP-14653 . Update joda-time version to 2.9.9. (rchiang) (rchiang: rev a6432ba5a177ec3d3a95fa79e313a9bbc531a1e7)
(edit) hadoop-project/pom.xml
(edit) NOTICE.txt
Initial patch. Still pending some testing.