Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14611

NetworkTopology.DEFAULT_HOST_LEVEL is unused

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha3
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      templedf Daniel Templeton added a comment -

      Thanks for the patch, Chen Liang. Committed to trunk and branch-2.

      Show
      templedf Daniel Templeton added a comment - Thanks for the patch, Chen Liang . Committed to trunk and branch-2.
      Hide
      vagarychen Chen Liang added a comment -

      Thanks Daniel Templeton! Looks like this has been checked in. So I'll go close this JIRA.

      Show
      vagarychen Chen Liang added a comment - Thanks Daniel Templeton ! Looks like this has been checked in. So I'll go close this JIRA.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11953 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11953/)
      HADOOP-14611. NetworkTopology.DEFAULT_HOST_LEVEL is unused (Contributed (templedf: rev 5a75f73893567151f525950cc1a15b3f1bfeac26)

      • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11953 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11953/ ) HADOOP-14611 . NetworkTopology.DEFAULT_HOST_LEVEL is unused (Contributed (templedf: rev 5a75f73893567151f525950cc1a15b3f1bfeac26) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
      Hide
      templedf Daniel Templeton added a comment -

      LGTM +1. I'll commit it later.

      Show
      templedf Daniel Templeton added a comment - LGTM +1. I'll commit it later.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 17s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 17m 3s trunk passed
      +1 compile 18m 46s trunk passed
      +1 checkstyle 0m 36s trunk passed
      +1 mvnsite 1m 17s trunk passed
      +1 findbugs 2m 1s trunk passed
      +1 javadoc 1m 1s trunk passed
      +1 mvninstall 0m 50s the patch passed
      +1 compile 14m 20s the patch passed
      +1 javac 14m 20s the patch passed
      +1 checkstyle 0m 38s the patch passed
      +1 mvnsite 1m 17s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 10s the patch passed
      +1 javadoc 0m 59s the patch passed
      -1 unit 9m 58s hadoop-common in the patch failed.
      +1 asflicense 0m 34s The patch does not generate ASF License warnings.
      73m 42s



      Reason Tests
      Failed junit tests hadoop.security.TestShellBasedUnixGroupsMapping



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue HADOOP-14611
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875086/HADOOP-14611.001.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 2afbe873fbc9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / b08cc97
      Default Java 1.8.0_131
      findbugs v3.1.0-RC1
      unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12661/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
      Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12661/testReport/
      modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12661/console
      Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 17m 3s trunk passed +1 compile 18m 46s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 17s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 1s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 14m 20s the patch passed +1 javac 14m 20s the patch passed +1 checkstyle 0m 38s the patch passed +1 mvnsite 1m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 0m 59s the patch passed -1 unit 9m 58s hadoop-common in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 73m 42s Reason Tests Failed junit tests hadoop.security.TestShellBasedUnixGroupsMapping Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14611 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875086/HADOOP-14611.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2afbe873fbc9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b08cc97 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12661/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12661/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12661/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      vagarychen Chen Liang added a comment -

      Thanks Daniel Templeton for reporting this! Post v001 patch to remove it.

      Show
      vagarychen Chen Liang added a comment - Thanks Daniel Templeton for reporting this! Post v001 patch to remove it.

        People

        • Assignee:
          vagarychen Chen Liang
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development