Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14581

Restrict setOwner to list of user when security is enabled in wasb

    Details

      Description

      Currently in azure FS, setOwner api is exposed to all the users accessing the file system.
      When Authorization is enabled, access to some files/folders is given to particular users based on whether the user is the owner of the file.
      So setOwner has to be restricted to limited set of users to prevent users from exploiting owner based authorization of files and folders.

      Introducing a new config called fs.azure.chown.allowed.userlist which is a comma seperated list of users who are allowed to perform chown operation when authorization is enabled.

      1. HADOOP-14581.1.patch
        9 kB
        Varada Hemeswari
      2. HADOOP-14581.2.patch
        11 kB
        Varada Hemeswari
      3. HADOOP-14581.4.patch
        12 kB
        Varada Hemeswari
      4. HADOOP-14581-003.patch
        11 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          (Had to add a second patch to get branch-2 to compile; java 7 doesn't like us using non-final variables in inner classes/closures. My fault for not testing the branch-2 build before committing it)

          Show
          stevel@apache.org Steve Loughran added a comment - (Had to add a second patch to get branch-2 to compile; java 7 doesn't like us using non-final variables in inner classes/closures. My fault for not testing the branch-2 build before committing it)
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11992 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11992/)
          HADOOP-14581. Restrict setOwner to list of user when security is enabled (stevel: rev 7d272ea124615c493c60ad454fbd6f144dd3cc24)

          • (edit) hadoop-tools/hadoop-azure/src/site/markdown/index.md
          • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java
          • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11992 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11992/ ) HADOOP-14581 . Restrict setOwner to list of user when security is enabled (stevel: rev 7d272ea124615c493c60ad454fbd6f144dd3cc24) (edit) hadoop-tools/hadoop-azure/src/site/markdown/index.md (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM

          +1
          committed!

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM +1 committed!
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 23s trunk passed
          +1 compile 0m 18s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 21s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 15s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 17s the patch passed
          +1 compile 0m 16s the patch passed
          +1 javac 0m 16s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 mvnsite 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 11s the patch passed
                Other Tests
          +1 unit 1m 22s hadoop-azure in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          19m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14581
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876767/HADOOP-14581.4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b5ab0dca13c8 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ac0a04a
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12767/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12767/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 23s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 21s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 15s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 1m 22s hadoop-azure in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 19m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14581 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876767/HADOOP-14581.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b5ab0dca13c8 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ac0a04a Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12767/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12767/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vahemesw Varada Hemeswari added a comment -

          Steve Loughran,I have addressed your documentation and check style comments in patch - 4.
          Here is the snippet of tests run against Azure South India endpoint.

          [INFO] --- maven-surefire-plugin:2.17:test (default-test) @ hadoop-azure ---
          [INFO] Surefire report directory: E:\2\hadoop\hadoop-tools\hadoop-azure\target\surefire-reports
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractAppend
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 11.617 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractAppend
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractCreate
          Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.339 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractCreate
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDelete
          Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.531 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDelete
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDistCp
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 88.856 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDistCp
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractGetFileStatus
          Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.887 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractGetFileStatus
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractMkdir
          Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.743 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractMkdir
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractOpen
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.879 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractOpen
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractRename
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.626 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractRename
          Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractSeek
          Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.695 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractSeek
          Running org.apache.hadoop.fs.azure.metrics.TestAzureFileSystemInstrumentation
          Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.745 sec - in org.apache.hadoop.fs.azure.metrics.TestAzureFileSystemInstrumentation
          Running org.apache.hadoop.fs.azure.metrics.TestBandwidthGaugeUpdater
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.671 sec - in org.apache.hadoop.fs.azure.metrics.TestBandwidthGaugeUpdater
          Running org.apache.hadoop.fs.azure.metrics.TestNativeAzureFileSystemMetricsSystem
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.579 sec - in org.apache.hadoop.fs.azure.metrics.TestNativeAzureFileSystemMetricsSystem
          Running org.apache.hadoop.fs.azure.metrics.TestRollingWindowAverage
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.266 sec - in org.apache.hadoop.fs.azure.metrics.TestRollingWindowAverage
          Running org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIo
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.682 sec - in org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIo
          Running org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIoWithSecureMode
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.501 sec - in org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIoWithSecureMode
          Running org.apache.hadoop.fs.azure.TestAzureFileSystemErrorConditions
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.525 sec - in org.apache.hadoop.fs.azure.TestAzureFileSystemErrorConditions
          Running org.apache.hadoop.fs.azure.TestBlobDataValidation
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.12 sec - in org.apache.hadoop.fs.azure.TestBlobDataValidation
          Running org.apache.hadoop.fs.azure.TestBlobMetadata
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.099 sec - in org.apache.hadoop.fs.azure.TestBlobMetadata
          Running org.apache.hadoop.fs.azure.TestBlobTypeSpeedDifference
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.546 sec - in org.apache.hadoop.fs.azure.TestBlobTypeSpeedDifference
          Running org.apache.hadoop.fs.azure.TestContainerChecks
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.339 sec - in org.apache.hadoop.fs.azure.TestContainerChecks
          Running org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionHandling
          Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.609 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionHandling
          Running org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionMessage
          Tests run: 47, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 295.493 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionMessage
          Running org.apache.hadoop.fs.azure.TestFileSystemOperationsExceptionHandlingMultiThreaded
          Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.649 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationsExceptionHandlingMultiThread
          ed
          Running org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads
          Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 291.155 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAppend
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.576 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAppend
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAtomicRenameDirList
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.956 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAtomicRenameDirList
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorization
          Tests run: 25, Failures: 0, Errors: 0, Skipped: 25, Time elapsed: 5.257 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorization
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorizationWithOwner
          Tests run: 28, Failures: 0, Errors: 0, Skipped: 28, Time elapsed: 5.333 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorizationWithOwner
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemBlockLocations
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.762 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemBlockLocations
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemClientLogging
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.098 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemClientLogging
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrency
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.124 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrency
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrencyLive
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.045 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrencyLive
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractEmulator
          Tests run: 43, Failures: 0, Errors: 0, Skipped: 43, Time elapsed: 0.975 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractEmulator
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractLive
          Tests run: 43, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 84.269 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractLive
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractMocked
          Tests run: 43, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 3.232 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractMocked
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractPageBlobLive
          Tests run: 43, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 92.51 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractPageBlobLive
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemFileNameCheck
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.538 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemFileNameCheck
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemLive
          Tests run: 51, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 312.294 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemLive
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemMocked
          Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.218 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemMocked
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked
          Tests run: 50, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 3.611 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked
          Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemUploadLogic
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.118 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemUploadLogic
          Running org.apache.hadoop.fs.azure.TestNativeAzureFSPageBlobLive
          Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 326.113 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFSPageBlobLive
          Running org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperations
          Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.628 sec - in org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperations
          Running org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperationsLive
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.5 sec - in org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperationsLive
          Running org.apache.hadoop.fs.azure.TestReadAndSeekPageBlobAfterWrite
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.96 sec - in org.apache.hadoop.fs.azure.TestReadAndSeekPageBlobAfterWrite
          Running org.apache.hadoop.fs.azure.TestShellDecryptionKeyProvider
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.531 sec - in org.apache.hadoop.fs.azure.TestShellDecryptionKeyProvider
          Running org.apache.hadoop.fs.azure.TestWasbFsck
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 1.458 sec - in org.apache.hadoop.fs.azure.TestWasbFsck
          Running org.apache.hadoop.fs.azure.TestWasbRemoteCallHelper
          Tests run: 10, Failures: 0, Errors: 0, Skipped: 10, Time elapsed: 2.855 sec - in org.apache.hadoop.fs.azure.TestWasbRemoteCallHelper
          Running org.apache.hadoop.fs.azure.TestWasbUriAndConfiguration
          Tests run: 18, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 10.009 sec - in org.apache.hadoop.fs.azure.TestWasbUriAndConfiguration
          
          Results :
          
          Tests run: 715, Failures: 0, Errors: 0, Skipped: 129
          
          [INFO]
          [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-azure ---
          [INFO] Building jar: E:\2\hadoop\hadoop-tools\hadoop-azure\target\hadoop-azure-3.0.0-beta1-SNAPSHOT.jar
          [INFO]
          [INFO] --- maven-site-plugin:3.5:attach-descriptor (attach-descriptor) @ hadoop-azure ---
          [INFO]
          [INFO] --- maven-jar-plugin:2.5:test-jar (default) @ hadoop-azure ---
          [INFO] Building jar: E:\2\hadoop\hadoop-tools\hadoop-azure\target\hadoop-azure-3.0.0-beta1-SNAPSHOT-tests.jar
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 37:19.687s
          [INFO] Finished at: Wed Jul 12 11:21:37 IST 2017
          [INFO] Final Memory: 37M/652M
          [INFO] ------------------------------------------------------------------------
          
          Show
          vahemesw Varada Hemeswari added a comment - Steve Loughran ,I have addressed your documentation and check style comments in patch - 4. Here is the snippet of tests run against Azure South India endpoint. [INFO] --- maven-surefire-plugin:2.17:test ( default -test) @ hadoop-azure --- [INFO] Surefire report directory: E:\2\hadoop\hadoop-tools\hadoop-azure\target\surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractAppend Tests run: 5, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 11.617 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractAppend Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractCreate Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.339 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractCreate Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDelete Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.531 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDelete Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDistCp Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 88.856 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractDistCp Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractGetFileStatus Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.887 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractGetFileStatus Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractMkdir Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.743 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractMkdir Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractOpen Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.879 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractOpen Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractRename Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.626 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractRename Running org.apache.hadoop.fs.azure.contract.TestAzureNativeContractSeek Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.695 sec - in org.apache.hadoop.fs.azure.contract.TestAzureNativeContractSeek Running org.apache.hadoop.fs.azure.metrics.TestAzureFileSystemInstrumentation Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.745 sec - in org.apache.hadoop.fs.azure.metrics.TestAzureFileSystemInstrumentation Running org.apache.hadoop.fs.azure.metrics.TestBandwidthGaugeUpdater Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.671 sec - in org.apache.hadoop.fs.azure.metrics.TestBandwidthGaugeUpdater Running org.apache.hadoop.fs.azure.metrics.TestNativeAzureFileSystemMetricsSystem Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.579 sec - in org.apache.hadoop.fs.azure.metrics.TestNativeAzureFileSystemMetricsSystem Running org.apache.hadoop.fs.azure.metrics.TestRollingWindowAverage Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.266 sec - in org.apache.hadoop.fs.azure.metrics.TestRollingWindowAverage Running org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIo Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.682 sec - in org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIo Running org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIoWithSecureMode Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.501 sec - in org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIoWithSecureMode Running org.apache.hadoop.fs.azure.TestAzureFileSystemErrorConditions Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.525 sec - in org.apache.hadoop.fs.azure.TestAzureFileSystemErrorConditions Running org.apache.hadoop.fs.azure.TestBlobDataValidation Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.12 sec - in org.apache.hadoop.fs.azure.TestBlobDataValidation Running org.apache.hadoop.fs.azure.TestBlobMetadata Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.099 sec - in org.apache.hadoop.fs.azure.TestBlobMetadata Running org.apache.hadoop.fs.azure.TestBlobTypeSpeedDifference Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.546 sec - in org.apache.hadoop.fs.azure.TestBlobTypeSpeedDifference Running org.apache.hadoop.fs.azure.TestContainerChecks Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.339 sec - in org.apache.hadoop.fs.azure.TestContainerChecks Running org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionHandling Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.609 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionHandling Running org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionMessage Tests run: 47, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 295.493 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationExceptionMessage Running org.apache.hadoop.fs.azure.TestFileSystemOperationsExceptionHandlingMultiThreaded Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.649 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationsExceptionHandlingMultiThread ed Running org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 291.155 sec - in org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAppend Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 66.576 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAppend Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAtomicRenameDirList Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.956 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAtomicRenameDirList Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorization Tests run: 25, Failures: 0, Errors: 0, Skipped: 25, Time elapsed: 5.257 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorization Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorizationWithOwner Tests run: 28, Failures: 0, Errors: 0, Skipped: 28, Time elapsed: 5.333 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemAuthorizationWithOwner Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemBlockLocations Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.762 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemBlockLocations Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemClientLogging Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.098 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemClientLogging Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrency Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.124 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrency Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrencyLive Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.045 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemConcurrencyLive Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractEmulator Tests run: 43, Failures: 0, Errors: 0, Skipped: 43, Time elapsed: 0.975 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractEmulator Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractLive Tests run: 43, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 84.269 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractLive Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractMocked Tests run: 43, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 3.232 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractMocked Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractPageBlobLive Tests run: 43, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 92.51 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemContractPageBlobLive Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemFileNameCheck Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.538 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemFileNameCheck Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemLive Tests run: 51, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 312.294 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemLive Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemMocked Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.218 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemMocked Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked Tests run: 50, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 3.611 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked Running org.apache.hadoop.fs.azure.TestNativeAzureFileSystemUploadLogic Tests run: 3, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.118 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFileSystemUploadLogic Running org.apache.hadoop.fs.azure.TestNativeAzureFSPageBlobLive Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 326.113 sec - in org.apache.hadoop.fs.azure.TestNativeAzureFSPageBlobLive Running org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperations Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.628 sec - in org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperations Running org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperationsLive Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.5 sec - in org.apache.hadoop.fs.azure.TestOutOfBandAzureBlobOperationsLive Running org.apache.hadoop.fs.azure.TestReadAndSeekPageBlobAfterWrite Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.96 sec - in org.apache.hadoop.fs.azure.TestReadAndSeekPageBlobAfterWrite Running org.apache.hadoop.fs.azure.TestShellDecryptionKeyProvider Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.531 sec - in org.apache.hadoop.fs.azure.TestShellDecryptionKeyProvider Running org.apache.hadoop.fs.azure.TestWasbFsck Tests run: 2, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 1.458 sec - in org.apache.hadoop.fs.azure.TestWasbFsck Running org.apache.hadoop.fs.azure.TestWasbRemoteCallHelper Tests run: 10, Failures: 0, Errors: 0, Skipped: 10, Time elapsed: 2.855 sec - in org.apache.hadoop.fs.azure.TestWasbRemoteCallHelper Running org.apache.hadoop.fs.azure.TestWasbUriAndConfiguration Tests run: 18, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 10.009 sec - in org.apache.hadoop.fs.azure.TestWasbUriAndConfiguration Results : Tests run: 715, Failures: 0, Errors: 0, Skipped: 129 [INFO] [INFO] --- maven-jar-plugin:2.5:jar ( default -jar) @ hadoop-azure --- [INFO] Building jar: E:\2\hadoop\hadoop-tools\hadoop-azure\target\hadoop-azure-3.0.0-beta1-SNAPSHOT.jar [INFO] [INFO] --- maven-site-plugin:3.5:attach-descriptor (attach-descriptor) @ hadoop-azure --- [INFO] [INFO] --- maven-jar-plugin:2.5:test-jar ( default ) @ hadoop-azure --- [INFO] Building jar: E:\2\hadoop\hadoop-tools\hadoop-azure\target\hadoop-azure-3.0.0-beta1-SNAPSHOT-tests.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 37:19.687s [INFO] Finished at: Wed Jul 12 11:21:37 IST 2017 [INFO] Final Memory: 37M/652M [INFO] ------------------------------------------------------------------------
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 8s trunk passed
          +1 compile 0m 18s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 20s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 14s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 17s the patch passed
          +1 compile 0m 16s the patch passed
          -1 javac 0m 16s hadoop-tools_hadoop-azure generated 4 new + 5 unchanged - 0 fixed = 9 total (was 5)
          -0 checkstyle 0m 11s hadoop-tools/hadoop-azure: The patch generated 2 new + 27 unchanged - 0 fixed = 29 total (was 27)
          +1 mvnsite 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 11s the patch passed
                Other Tests
          +1 unit 1m 20s hadoop-azure in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          19m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14581
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876604/HADOOP-14581-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 13c70e183a42 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3a7f02b
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/artifact/patchprocess/diff-compile-javac-hadoop-tools_hadoop-azure.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 8s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 20s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed -1 javac 0m 16s hadoop-tools_hadoop-azure generated 4 new + 5 unchanged - 0 fixed = 9 total (was 5) -0 checkstyle 0m 11s hadoop-tools/hadoop-azure: The patch generated 2 new + 27 unchanged - 0 fixed = 29 total (was 27) +1 mvnsite 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 1m 20s hadoop-azure in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 19m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14581 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876604/HADOOP-14581-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 13c70e183a42 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3a7f02b Default Java 1.8.0_131 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/artifact/patchprocess/diff-compile-javac-hadoop-tools_hadoop-azure.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12762/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 003

          This is just patch 002 with the conflict in TestNativeAzureFileSystemAuthorization with HADOOP-14443 fixed, and the new imports re-orded to go with our preferred layout.

          Varada Hemeswari this is ready apart from checkstyle. & docs

          Remember to hit the "submit patch" button to run it by Yetus. It doesn't run the azure test (hence the need to explicitly declare it), but it does run it through our style checks, and once HADOOP-14553 splits up unit and integration tests, the mock tests will be run by yetus.

          1. Here a lot of the code is going to be rejected by the line with. Apart from the special cases where some wider lines helps readability, the project requires lines to be <= 80 chars wide. Why? it's so that the git patch viewer can do side-by-side checking better.
          2. Needs documentation in hadoop-tools/hadoop-azure/src/site/markdown/index.md . No good having new features if they are kept secret.

          Thanks

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 003 This is just patch 002 with the conflict in TestNativeAzureFileSystemAuthorization with HADOOP-14443 fixed, and the new imports re-orded to go with our preferred layout. Varada Hemeswari this is ready apart from checkstyle. & docs Remember to hit the "submit patch" button to run it by Yetus. It doesn't run the azure test (hence the need to explicitly declare it), but it does run it through our style checks, and once HADOOP-14553 splits up unit and integration tests, the mock tests will be run by yetus. Here a lot of the code is going to be rejected by the line with. Apart from the special cases where some wider lines helps readability, the project requires lines to be <= 80 chars wide. Why? it's so that the git patch viewer can do side-by-side checking better. Needs documentation in hadoop-tools/hadoop-azure/src/site/markdown/index.md . No good having new features if they are kept secret. Thanks
          Hide
          vahemesw Varada Hemeswari added a comment -

          Hi Steve/Ming Liang,

          Can you please review the latest patch at your earliest possible?
          Pinging again since we are running tight on deadlines

          Thanks and regards,
          Hema

          Show
          vahemesw Varada Hemeswari added a comment - Hi Steve/Ming Liang, Can you please review the latest patch at your earliest possible? Pinging again since we are running tight on deadlines Thanks and regards, Hema
          Hide
          vahemesw Varada Hemeswari added a comment -

          Steve Loughran, Mingliang Liu Can you please take a look at the recent patch?

          Show
          vahemesw Varada Hemeswari added a comment - Steve Loughran , Mingliang Liu Can you please take a look at the recent patch?
          Hide
          vahemesw Varada Hemeswari added a comment -

          I think here you could actually use getStrings() to get the list, and treat an empty list as the same as an entry "*": all. Why use that method? Existing regression tests.

          --> I am using * to allow all users and "" to not allow anyone. So they could not be treated as same. There are no existing tests that regressed due to this.

          needs policy for: * in the string: maybe fail fast for illegal setup?
          --> taken care of, in patch2

          needs policy for "". Right now it probably fails. Should it be a skip.
          --> The failure is intentional. We expect the property to be setup as '' default value or with list of users. In case it is setup as "", it translates to no one is allowed to chown.*

          TestNativeAzureFileSystemAuthorization
          try a string like "user1,user2 , user3 ,,user4 " to see what happens. I'd expect the leading/trailing spaces stripped, empty element skipped.
          --> Patch2 tests includes this list
          also try " user1, *" to verify that it gets rejected.
          -->added a test for this in patch 2

          I tested the hadoop-azure module changes on 'vahemeswregion.blob.core.windows.net' storage account

          Thanks.

          Show
          vahemesw Varada Hemeswari added a comment - I think here you could actually use getStrings() to get the list, and treat an empty list as the same as an entry "*": all. Why use that method? Existing regression tests. --> I am using * to allow all users and "" to not allow anyone. So they could not be treated as same. There are no existing tests that regressed due to this. needs policy for: * in the string: maybe fail fast for illegal setup? --> taken care of, in patch2 needs policy for "". Right now it probably fails. Should it be a skip. --> The failure is intentional. We expect the property to be setup as ' ' default value or with list of users. In case it is setup as "", it translates to no one is allowed to chown.* TestNativeAzureFileSystemAuthorization try a string like "user1,user2 , user3 ,,user4 " to see what happens. I'd expect the leading/trailing spaces stripped, empty element skipped. --> Patch2 tests includes this list also try " user1, *" to verify that it gets rejected. -->added a test for this in patch 2 I tested the hadoop-azure module changes on 'vahemeswregion.blob.core.windows.net' storage account Thanks.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          NativeAzureFileSystem

          2966: You should use getTrimmed to have leading, trailing whitespace cut; we do that for all new properties.

          I think here you could actually use getStrings() to get the list, and treat an empty list as the same as an entry "*": all. Why use that method? Existing regression tests.

          • needs policy for: * in the string: maybe fail fast for illegal setup?
          • needs policy for "". Right now it probably fails. Should it be a skip.

          TestNativeAzureFileSystemAuthorization

          • try a string like "user1,user2 , user3 ,,user4 " to see what happens. I'd expect the leading/trailing spaces stripped, empty element skipped.
          • also try " user1, *" to verify that it gets rejected.

          Here's the test policy I'm writing down; a formalisation of what's been mentioned before
          https://github.com/steveloughran/hadoop/blob/azure/HADOOP-14553-testing/hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md

          for now, can you state which Azure endpoint you did a mvn -T 1C test run on the hadoop-azure module. Thanks.

          Other

          • Docs.
          Show
          stevel@apache.org Steve Loughran added a comment - NativeAzureFileSystem 2966: You should use getTrimmed to have leading, trailing whitespace cut; we do that for all new properties. I think here you could actually use getStrings() to get the list, and treat an empty list as the same as an entry "*": all. Why use that method? Existing regression tests. needs policy for: * in the string: maybe fail fast for illegal setup? needs policy for "". Right now it probably fails. Should it be a skip. TestNativeAzureFileSystemAuthorization try a string like "user1,user2 , user3 ,,user4 " to see what happens. I'd expect the leading/trailing spaces stripped, empty element skipped. also try " user1, *" to verify that it gets rejected. Here's the test policy I'm writing down; a formalisation of what's been mentioned before https://github.com/steveloughran/hadoop/blob/azure/HADOOP-14553-testing/hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md for now, can you state which Azure endpoint you did a mvn -T 1C test run on the hadoop-azure module. Thanks. Other Docs.

            People

            • Assignee:
              vahemesw Varada Hemeswari
              Reporter:
              vahemesw Varada Hemeswari
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Development