Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14365 Stabilise FileSystem builder-based create API
  3. HADOOP-14538

Fix TestFilterFileSystem and TestHarFileSystem failures after DistributedFileSystem.append API

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: fs
    • Labels:
      None

      Description

      Two tests are failed after HADOOP-14395.

      TestFilterFileSystem.testFilterFileSystem
      TestHarFileSystem.testInheritedMethodsImplemented
      

        Issue Links

          Activity

          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Add missing override to FilterFileSystem and HarFilterSystem to fix failures in TestHarFileSystem an TestFilterFileSystem.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Add missing override to FilterFileSystem and HarFilterSystem to fix failures in TestHarFileSystem an TestFilterFileSystem .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 32s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 19s trunk passed
          +1 compile 13m 31s trunk passed
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 1m 4s trunk passed
          -1 findbugs 1m 21s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 0m 49s trunk passed
          +1 mvninstall 0m 38s the patch passed
          +1 compile 10m 6s the patch passed
          +1 javac 10m 6s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 50s the patch passed
          +1 unit 7m 59s hadoop-common in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          57m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14538
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873421/HADOOP-14538.00.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1598c2dac79e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7582ded
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12562/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12562/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12562/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 19s trunk passed +1 compile 13m 31s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 4s trunk passed -1 findbugs 1m 21s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 49s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 10m 6s the patch passed +1 javac 10m 6s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 7m 59s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 57m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14538 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873421/HADOOP-14538.00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1598c2dac79e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7582ded Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12562/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12562/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12562/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          +1,lgtm.

          Show
          brahmareddy Brahma Reddy Battula added a comment - +1,lgtm.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1

          Show
          ajisakaa Akira Ajisaka added a comment - +1
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Lei (Eddy) Xu for the quick fix and thanks Brahma Reddy Battula for the review.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Lei (Eddy) Xu for the quick fix and thanks Brahma Reddy Battula for the review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11883 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11883/)
          HADOOP-14538. Fix TestFilterFileSystem and TestHarFileSystem failures (aajisaka: rev 7ade5124b8b6c52a084ec187c531017eee0f1884)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11883 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11883/ ) HADOOP-14538 . Fix TestFilterFileSystem and TestHarFileSystem failures (aajisaka: rev 7ade5124b8b6c52a084ec187c531017eee0f1884) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFileSystem.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks a lot for the review and commit, Brahma Reddy Battula, Akira Ajisaka!

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for the review and commit, Brahma Reddy Battula , Akira Ajisaka !

            People

            • Assignee:
              eddyxu Lei (Eddy) Xu
              Reporter:
              eddyxu Lei (Eddy) Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development