[HADOOP-14533] Size of args cannot be less than zero in TraceAdmin#run as its linkedlist

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
• Component/s: common, tracing
• Hadoop Flags: Reviewed
• Assignee: Weisen Han
• Reporter: Weisen Han
• Created: 16/Jun/17 15:29
• Updated: 21/Jun/17 16:45
• Resolved: 20/Jun/17 12:58

Description

  @Override
  public int run(String argv[]) throws Exception {
      LinkedList<String> args = new LinkedList<String>();
      ……
         if (args.size() < 0) {
            System.err.println("You must specify an operation.");
                 return 1;
        }
……
}

From the code above, the args is a linklist obejct, so it cannot be less than zero.meaning that code below is wrong

 if (args.size() < 0) {
      System.err.println("You must specify an operation.");
      return 1;
    }