Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: common
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RollingAverages metric extends on MutableRatesWithAggregation metric and maintains a group of rolling average metrics. This class should be allowed to register as a metric with the MetricSystem.

      1. HADOOP-14503.001.patch
        29 kB
        Hanisha Koneru
      2. HADOOP-14503.002.patch
        29 kB
        Hanisha Koneru
      3. HADOOP-14503.003.patch
        39 kB
        Hanisha Koneru
      4. HADOOP-14503.004.patch
        40 kB
        Hanisha Koneru
      5. HADOOP-14503.005.patch
        39 kB
        Hanisha Koneru
      6. HADOOP-14503.006.patch
        46 kB
        Hanisha Koneru
      7. HADOOP-14503.007.patch
        47 kB
        Hanisha Koneru
      8. HADOOP-14503-branch-2.001.patch
        47 kB
        Hanisha Koneru

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 24s Maven dependency ordering for branch
          +1 mvninstall 13m 12s trunk passed
          +1 compile 13m 42s trunk passed
          +1 checkstyle 1m 54s trunk passed
          +1 mvnsite 2m 4s trunk passed
          -1 findbugs 1m 27s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 40s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 32s the patch passed
          +1 compile 10m 18s the patch passed
          +1 javac 10m 18s the patch passed
          -0 checkstyle 1m 58s root: The patch generated 8 new + 35 unchanged - 1 fixed = 43 total (was 36)
          +1 mvnsite 2m 13s the patch passed
          -1 whitespace 0m 0s The patch 1 line(s) with tabs.
          +1 findbugs 3m 51s the patch passed
          +1 javadoc 1m 47s the patch passed
          -1 unit 7m 45s hadoop-common in the patch failed.
          -1 unit 78m 42s hadoop-hdfs in the patch failed.
          +1 asflicense 1m 1s The patch does not generate ASF License warnings.
          168m 32s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871964/HADOOP-14503.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fa1113208b71 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5672ae7
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 24s Maven dependency ordering for branch +1 mvninstall 13m 12s trunk passed +1 compile 13m 42s trunk passed +1 checkstyle 1m 54s trunk passed +1 mvnsite 2m 4s trunk passed -1 findbugs 1m 27s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 10m 18s the patch passed +1 javac 10m 18s the patch passed -0 checkstyle 1m 58s root: The patch generated 8 new + 35 unchanged - 1 fixed = 43 total (was 36) +1 mvnsite 2m 13s the patch passed -1 whitespace 0m 0s The patch 1 line(s) with tabs. +1 findbugs 3m 51s the patch passed +1 javadoc 1m 47s the patch passed -1 unit 7m 45s hadoop-common in the patch failed. -1 unit 78m 42s hadoop-hdfs in the patch failed. +1 asflicense 1m 1s The patch does not generate ASF License warnings. 168m 32s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12871964/HADOOP-14503.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fa1113208b71 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5672ae7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12474/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for contributing this improvement Hanisha Koneru. A few comments:

          1. The following log message should be debug in both constructor and init.
                LOG.info("MutableRollingAverages has been initialized with default values: " +
                    "Window Size = " + WINDOW_SIZE_MS_DEFAULT + "ms " +
                    ", Number of Windows = " + NUM_WINDOWS_DEFAULT +
                    " and Metric value name = " + METRIC_VALUE_NAME_DEFAULT);
            
          2. The init method should be synchronized.
          3. init should cancel the previously scheduled task in the constructor.
          4. Also the SCHEDULER.scheduleAtFixedRate call can be skipped if init() is invoked with the same windowSizeMs and numWindows as before.
          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for contributing this improvement Hanisha Koneru . A few comments: The following log message should be debug in both constructor and init. LOG.info( "MutableRollingAverages has been initialized with default values: " + "Window Size = " + WINDOW_SIZE_MS_DEFAULT + "ms " + ", Number of Windows = " + NUM_WINDOWS_DEFAULT + " and Metric value name = " + METRIC_VALUE_NAME_DEFAULT); The init method should be synchronized. init should cancel the previously scheduled task in the constructor. Also the SCHEDULER.scheduleAtFixedRate call can be skipped if init() is invoked with the same windowSizeMs and numWindows as before.
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thanks for the review, Arpit Agarwal.
          I have addressed your comments in patch v02.
          The unit test failures are unrelated to the patch.

          Show
          hanishakoneru Hanisha Koneru added a comment - Thanks for the review, Arpit Agarwal . I have addressed your comments in patch v02. The unit test failures are unrelated to the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 31s Maven dependency ordering for branch
          +1 mvninstall 13m 22s trunk passed
          +1 compile 14m 49s trunk passed
          +1 checkstyle 2m 6s trunk passed
          +1 mvnsite 2m 35s trunk passed
          -1 findbugs 1m 43s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 47s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 36s the patch passed
          +1 compile 10m 23s the patch passed
          +1 javac 10m 23s the patch passed
          -0 checkstyle 1m 57s root: The patch generated 4 new + 35 unchanged - 1 fixed = 39 total (was 36)
          +1 mvnsite 2m 6s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 57s the patch passed
          +1 javadoc 1m 48s the patch passed
          -1 unit 7m 19s hadoop-common in the patch failed.
          -1 unit 63m 45s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 44s The patch does not generate ASF License warnings.
          155m 45s



          Reason Tests
          Failed junit tests hadoop.metrics2.lib.TestRollingAverages
            hadoop.hdfs.server.datanode.metrics.TestDataNodeOutlierDetectionViaMetrics
            hadoop.hdfs.server.datanode.TestDataNodePeerMetrics
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872155/HADOOP-14503.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3da967837c1d 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7c9694c
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 13m 22s trunk passed +1 compile 14m 49s trunk passed +1 checkstyle 2m 6s trunk passed +1 mvnsite 2m 35s trunk passed -1 findbugs 1m 43s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 47s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 36s the patch passed +1 compile 10m 23s the patch passed +1 javac 10m 23s the patch passed -0 checkstyle 1m 57s root: The patch generated 4 new + 35 unchanged - 1 fixed = 39 total (was 36) +1 mvnsite 2m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 57s the patch passed +1 javadoc 1m 48s the patch passed -1 unit 7m 19s hadoop-common in the patch failed. -1 unit 63m 45s hadoop-hdfs in the patch failed. +1 asflicense 0m 44s The patch does not generate ASF License warnings. 155m 45s Reason Tests Failed junit tests hadoop.metrics2.lib.TestRollingAverages   hadoop.hdfs.server.datanode.metrics.TestDataNodeOutlierDetectionViaMetrics   hadoop.hdfs.server.datanode.TestDataNodePeerMetrics   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872155/HADOOP-14503.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3da967837c1d 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7c9694c Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12487/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Updated patch v03 with the following change:
          Discarding any existing samples if RollingAverages parameters (Window size or Num Windows) is changed.
          Thanks Arpit Agarwal for pointing it out.

          Show
          hanishakoneru Hanisha Koneru added a comment - Updated patch v03 with the following change: Discarding any existing samples if RollingAverages parameters (Window size or Num Windows) is changed. Thanks Arpit Agarwal for pointing it out.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the updated patch Hanisha Koneru. A couple of comments:

          1. init also needs to reset snapshot and averages here:
                if (hasChanged) {
                  if (scheduledTask != null) {
                    scheduledTask.cancel(true);
                  }
                  // Discard previously collected samples as windowSize and/or numWindows
                  // has changed.
                  innerMetrics = new MutableRatesWithAggregation();
            
          2. Unused method MutableRollingAverages#rename.

          Also the failed unit tests from the v2 patch Jenkins run look related.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the updated patch Hanisha Koneru . A couple of comments: init also needs to reset snapshot and averages here: if (hasChanged) { if (scheduledTask != null ) { scheduledTask.cancel( true ); } // Discard previously collected samples as windowSize and/or numWindows // has changed. innerMetrics = new MutableRatesWithAggregation(); Unused method MutableRollingAverages#rename. Also the failed unit tests from the v2 patch Jenkins run look related.
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thanks for the review Arpit Agarwal. Updated patch v04 to address the comments. And fixed failing unit tests.

          Show
          hanishakoneru Hanisha Koneru added a comment - Thanks for the review Arpit Agarwal . Updated patch v04 to address the comments. And fixed failing unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 46s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 38s Maven dependency ordering for branch
          +1 mvninstall 14m 27s trunk passed
          +1 compile 21m 37s trunk passed
          +1 checkstyle 2m 18s trunk passed
          +1 mvnsite 2m 13s trunk passed
          -1 findbugs 1m 34s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 40s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 11m 12s the patch passed
          +1 javac 11m 12s the patch passed
          -0 checkstyle 1m 57s root: The patch generated 4 new + 35 unchanged - 1 fixed = 39 total (was 36)
          +1 mvnsite 2m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 33s the patch passed
          +1 javadoc 1m 43s the patch passed
          +1 unit 8m 28s hadoop-common in the patch passed.
          -1 unit 86m 21s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 52s The patch does not generate ASF License warnings.
          187m 56s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.server.datanode.metrics.TestDataNodeOutlierDetectionViaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872338/HADOOP-14503.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fd64c1368660 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 325163f
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 38s Maven dependency ordering for branch +1 mvninstall 14m 27s trunk passed +1 compile 21m 37s trunk passed +1 checkstyle 2m 18s trunk passed +1 mvnsite 2m 13s trunk passed -1 findbugs 1m 34s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 11m 12s the patch passed +1 javac 11m 12s the patch passed -0 checkstyle 1m 57s root: The patch generated 4 new + 35 unchanged - 1 fixed = 39 total (was 36) +1 mvnsite 2m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 33s the patch passed +1 javadoc 1m 43s the patch passed +1 unit 8m 28s hadoop-common in the patch passed. -1 unit 86m 21s hadoop-hdfs in the patch failed. +1 asflicense 0m 52s The patch does not generate ASF License warnings. 187m 56s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.datanode.metrics.TestDataNodeOutlierDetectionViaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872338/HADOOP-14503.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fd64c1368660 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 325163f Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12505/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 13m 54s trunk passed
          +1 compile 16m 5s trunk passed
          +1 checkstyle 2m 1s trunk passed
          +1 mvnsite 2m 6s trunk passed
          -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 41s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 11m 9s the patch passed
          +1 javac 11m 9s the patch passed
          -0 checkstyle 2m 8s root: The patch generated 4 new + 35 unchanged - 1 fixed = 39 total (was 36)
          +1 mvnsite 2m 22s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 3m 38s the patch passed
          +1 javadoc 1m 56s the patch passed
          +1 unit 8m 0s hadoop-common in the patch passed.
          -1 unit 1m 0s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 42s The patch does not generate ASF License warnings.
          94m 0s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872362/HADOOP-14503.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ae47c0f0dce6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5578af8
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 13m 54s trunk passed +1 compile 16m 5s trunk passed +1 checkstyle 2m 1s trunk passed +1 mvnsite 2m 6s trunk passed -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 41s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 11m 9s the patch passed +1 javac 11m 9s the patch passed -0 checkstyle 2m 8s root: The patch generated 4 new + 35 unchanged - 1 fixed = 39 total (was 36) +1 mvnsite 2m 22s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 3m 38s the patch passed +1 javadoc 1m 56s the patch passed +1 unit 8m 0s hadoop-common in the patch passed. -1 unit 1m 0s hadoop-hdfs in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 94m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872362/HADOOP-14503.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ae47c0f0dce6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5578af8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12510/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          In patch v05, removed the init method. The default window size and num windows will be used when using the MutableRollingAverages as a metric registered with the metric system.
          Thanks Arpit Agarwal for the offline discussion.

          Show
          hanishakoneru Hanisha Koneru added a comment - In patch v05, removed the init method. The default window size and num windows will be used when using the MutableRollingAverages as a metric registered with the metric system. Thanks Arpit Agarwal for the offline discussion.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 37s Maven dependency ordering for branch
          +1 mvninstall 13m 20s trunk passed
          +1 compile 13m 35s trunk passed
          +1 checkstyle 1m 54s trunk passed
          +1 mvnsite 2m 6s trunk passed
          -1 findbugs 1m 26s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 41s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 31s the patch passed
          +1 compile 10m 11s the patch passed
          +1 javac 10m 11s the patch passed
          -0 checkstyle 1m 55s root: The patch generated 4 new + 34 unchanged - 2 fixed = 38 total (was 36)
          +1 mvnsite 2m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 34s the patch passed
          +1 javadoc 1m 44s the patch passed
          +1 unit 8m 1s hadoop-common in the patch passed.
          -1 unit 63m 4s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 42s The patch does not generate ASF License warnings.
          152m 45s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872464/HADOOP-14503.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 05f44d31ffd8 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e86eef9
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 37s Maven dependency ordering for branch +1 mvninstall 13m 20s trunk passed +1 compile 13m 35s trunk passed +1 checkstyle 1m 54s trunk passed +1 mvnsite 2m 6s trunk passed -1 findbugs 1m 26s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 41s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 10m 11s the patch passed +1 javac 10m 11s the patch passed -0 checkstyle 1m 55s root: The patch generated 4 new + 34 unchanged - 2 fixed = 38 total (was 36) +1 mvnsite 2m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 34s the patch passed +1 javadoc 1m 44s the patch passed +1 unit 8m 1s hadoop-common in the patch passed. -1 unit 63m 4s hadoop-hdfs in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 152m 45s Reason Tests Failed junit tests hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872464/HADOOP-14503.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 05f44d31ffd8 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e86eef9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12516/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 1m 40s Maven dependency ordering for branch
          +1 mvninstall 13m 59s trunk passed
          +1 compile 14m 8s trunk passed
          +1 checkstyle 2m 3s trunk passed
          +1 mvnsite 2m 11s trunk passed
          -1 findbugs 1m 31s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 41s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 10m 11s the patch passed
          +1 javac 10m 11s the patch passed
          -0 checkstyle 2m 4s root: The patch generated 4 new + 595 unchanged - 3 fixed = 599 total (was 598)
          +1 mvnsite 2m 8s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 3m 37s the patch passed
          +1 javadoc 1m 47s the patch passed
          +1 unit 7m 32s hadoop-common in the patch passed.
          -1 unit 70m 59s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 44s The patch does not generate ASF License warnings.
          161m 57s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872763/HADOOP-14503.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ced59ec04b28 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 86368cc
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 13m 59s trunk passed +1 compile 14m 8s trunk passed +1 checkstyle 2m 3s trunk passed +1 mvnsite 2m 11s trunk passed -1 findbugs 1m 31s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 41s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 10m 11s the patch passed +1 javac 10m 11s the patch passed -0 checkstyle 2m 4s root: The patch generated 4 new + 595 unchanged - 3 fixed = 599 total (was 598) +1 mvnsite 2m 8s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 37s the patch passed +1 javadoc 1m 47s the patch passed +1 unit 7m 32s hadoop-common in the patch passed. -1 unit 70m 59s hadoop-hdfs in the patch failed. +1 asflicense 0m 44s The patch does not generate ASF License warnings. 161m 57s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872763/HADOOP-14503.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ced59ec04b28 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86368cc Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12522/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks Hanisha Koneru. The patch lgtm. Can you please address the checkstyle issues? For the first checkstyle issue, you can add a private constructor to the MetricsTestHelper class and make it a final class.

          Also there is a pre-existing typo in DataNodePeerMetrics (sendPacketDownstreamRollingAvgerages). Could you please fix that too?

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks Hanisha Koneru . The patch lgtm. Can you please address the checkstyle issues? For the first checkstyle issue, you can add a private constructor to the MetricsTestHelper class and make it a final class. Also there is a pre-existing typo in DataNodePeerMetrics (sendPacketDownstreamRollingAvgerages). Could you please fix that too?
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thanks Arpit Agarwal for the review.
          I have addressed your comments in patch v07.
          The test failures are unrelated and pass locally.

          Show
          hanishakoneru Hanisha Koneru added a comment - Thanks Arpit Agarwal for the review. I have addressed your comments in patch v07. The test failures are unrelated and pass locally.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks Hanisha Koneru. +1 pending Jenkins.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks Hanisha Koneru . +1 pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 1m 26s Maven dependency ordering for branch
          +1 mvninstall 13m 19s trunk passed
          +1 compile 13m 33s trunk passed
          +1 checkstyle 1m 59s trunk passed
          +1 mvnsite 2m 3s trunk passed
          -1 findbugs 1m 28s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 40s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 32s the patch passed
          +1 compile 10m 16s the patch passed
          +1 javac 10m 16s the patch passed
          -0 checkstyle 2m 3s root: The patch generated 3 new + 595 unchanged - 3 fixed = 598 total (was 598)
          +1 mvnsite 2m 6s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 3m 33s the patch passed
          +1 javadoc 1m 43s the patch passed
          +1 unit 8m 57s hadoop-common in the patch passed.
          -1 unit 75m 13s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          165m 43s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14503
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872783/HADOOP-14503.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1cc0f3566a54 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b3d3ede
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 1m 26s Maven dependency ordering for branch +1 mvninstall 13m 19s trunk passed +1 compile 13m 33s trunk passed +1 checkstyle 1m 59s trunk passed +1 mvnsite 2m 3s trunk passed -1 findbugs 1m 28s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 10m 16s the patch passed +1 javac 10m 16s the patch passed -0 checkstyle 2m 3s root: The patch generated 3 new + 595 unchanged - 3 fixed = 598 total (was 598) +1 mvnsite 2m 6s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 33s the patch passed +1 javadoc 1m 43s the patch passed +1 unit 8m 57s hadoop-common in the patch passed. -1 unit 75m 13s hadoop-hdfs in the patch failed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 165m 43s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14503 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872783/HADOOP-14503.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1cc0f3566a54 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b3d3ede Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12523/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          I've committed this and fixed the checkstyle whitespace issue. Thank you for the contribution Hanisha Koneru.

          I hit some merge conflicts while applying the patch to branch-2. If you want to post a branch-2 patch I'd be happy to commit that too.

          Show
          arpitagarwal Arpit Agarwal added a comment - I've committed this and fixed the checkstyle whitespace issue. Thank you for the contribution Hanisha Koneru . I hit some merge conflicts while applying the patch to branch-2. If you want to post a branch-2 patch I'd be happy to commit that too.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11862 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11862/)
          HADOOP-14503. Make RollingAverages a mutable metric. Contributed by (arp: rev 8633ef8e10a78883fbd6bf197007dc5191bf4535)

          • (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableRollingAverages.java
          • (delete) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/RollingAverages.java
          • (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/MetricsTestHelper.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableMetricsFactory.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/metrics/TestDataNodeOutlierDetectionViaMetrics.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodePeerMetrics.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • (delete) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestRollingAverages.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodePeerMetrics.java
          • (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableRollingAverages.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11862 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11862/ ) HADOOP-14503 . Make RollingAverages a mutable metric. Contributed by (arp: rev 8633ef8e10a78883fbd6bf197007dc5191bf4535) (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableRollingAverages.java (delete) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/RollingAverages.java (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/MetricsTestHelper.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableMetricsFactory.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/metrics/TestDataNodeOutlierDetectionViaMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodePeerMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (delete) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestRollingAverages.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodePeerMetrics.java (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableRollingAverages.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Thanks for committing the patch, Arpit Agarwal.
          I will post a branch-2 patch soon.

          Show
          hanishakoneru Hanisha Koneru added a comment - Thanks for committing the patch, Arpit Agarwal . I will post a branch-2 patch soon.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for the branch-2 patch. I've committed it after compiling with JDK7 and running affected unit tests.

          Thanks Hanisha Koneru.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for the branch-2 patch. I've committed it after compiling with JDK7 and running affected unit tests. Thanks Hanisha Koneru .

            People

            • Assignee:
              hanishakoneru Hanisha Koneru
              Reporter:
              hanishakoneru Hanisha Koneru
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development