[HADOOP-14501] Switch from aalto-xml to woodstox to handle odd XML features

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.9.0, 3.0.0-alpha4
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Component/s: conf
• Target Version/s: 2.9.0, 3.0.0-alpha4
• Assignee: Jonathan Turner Eagles
• Reporter: Andrew Wang
• Created: 06/Jun/17 23:39
• Updated: 12/Jun/17 22:32
• Resolved: 12/Jun/17 22:20

Description

hgadre tried testing solr with a Hadoop 3 client. He saw various test case failures due to what look like functionality gaps in the new aalto-xml stax implementation pulled in by HADOOP-14216:

   [junit4]    > Throwable #1: com.fasterxml.aalto.WFCException: Illegal XML character ('ü' (code 252))
....
   [junit4]    > Caused by: com.fasterxml.aalto.WFCException: General entity reference (&bar;) encountered in entity expanding mode: operation not (yet) implemented
...
   [junit4]    > Throwable #1: org.apache.solr.common.SolrException: General entity reference (&wacky;) encountered in entity expanding mode: operation not (yet) implemented

These were from the following test case executions:

NOTE: reproduce with: ant test  -Dtestcase=DocumentAnalysisRequestHandlerTest -Dtests.method=testCharsetOutsideDocument -Dtests.seed=2F739D88D9C723CA -Dtests.slow=true -Dtests.locale=und -Dtests.timezone=Atlantic/Faeroe -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
NOTE: reproduce with: ant test  -Dtestcase=MBeansHandlerTest -Dtests.method=testXMLDiffWithExternalEntity -Dtests.seed=2F739D88D9C723CA -Dtests.slow=true -Dtests.locale=en-US -Dtests.timezone=US/Aleutian -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
NOTE: reproduce with: ant test  -Dtestcase=XmlUpdateRequestHandlerTest -Dtests.method=testExternalEntities -Dtests.seed=2F739D88D9C723CA -Dtests.slow=true -Dtests.locale=hr -Dtests.timezone=America/Barbados -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
NOTE: reproduce with: ant test  -Dtestcase=XmlUpdateRequestHandlerTest -Dtests.method=testNamedEntity -Dtests.seed=2F739D88D9C723CA -Dtests.slow=true -Dtests.locale=hr -Dtests.timezone=America/Barbados -Dtests.asserts=true -Dtests.file.encoding=US-ASCII

Issue Links

• is broken by: HADOOP-14216 Improve Configuration XML Parsing Performance