[HADOOP-14476] make InconsistentAmazonS3Client usable in downstream tests

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HADOOP-13345
• Fix Version/s: HADOOP-13345
• Component/s: fs/s3, test
• Target Version/s: HADOOP-13345
• Assignee: Aaron Fabbri
• Reporter: Steve Loughran
• Created: 01/Jun/17 13:55
• Updated: 08/Jun/17 18:10
• Resolved: 08/Jun/17 18:10

Description

It's important for downstream apps to be able to verify that s3guard works by making the AWS client inconsistent (so demonstrate problems), then turn s3guard on to verify that they go away.

This can be done by exposing the InconsistentAmazonS3Client

1. move the factory to the production source
2. make delay configurable for when you want a really long delay
3. have factory code log @ warn when a non-default factory is used.
4. mention in s3a testing.md

I think we could look at the name of the option, fs.s3a.s3.client.factory.impl too. I'd like something which has "internal" in it, and without the duplication of s3a.s3