[HADOOP-14470] CommandWithDestination#create used redundant ternary operator

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Duplicate
• Affects Version/s: 3.0.0-alpha3
• Component/s: common, fs
• Assignee: Hongyuan Li
• Reporter: Hongyuan Li
• Created: 31/May/17 15:58
• Updated: 04/Jul/17 11:52
• Resolved: 03/Jul/17 17:40

Description

in if statement，the lazyPersist is always true, thus the ternary operator is redundant，
lazyPersist == true in if statment, so lazyPersist ? 1 : getDefaultReplication(item.path) is redundant.

related code like below, which is in org.apache.hadoop.fs.shell.CommandWithDestination lineNumber : 504 :

   FSDataOutputStream create(PathData item, boolean lazyPersist,
        boolean direct)
        throws IOException {
      try {
        if (lazyPersist) { // in if stament, lazyPersist is always true
      ……
          return create(item.path,
                        FsPermission.getFileDefault().applyUMask(
                            FsPermission.getUMask(getConf())),
                        createFlags,
                        getConf().getInt(IO_FILE_BUFFER_SIZE_KEY,
                            IO_FILE_BUFFER_SIZE_DEFAULT),
                        lazyPersist ? 1 : getDefaultReplication(item.path), // *this is redundant*
                        getDefaultBlockSize(),
                        null,
                        null);
        } else {
          return create(item.path, true);
        }
      } finally { // might have been created but stream was interrupted
        if (!direct) {
          deleteOnExit(item.path);
        }
      }
    }

Issue Links

• Is contained by: HADOOP-12940 Fix warnings from Spotbugs in hadoop-common