Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14465

LdapGroupsMapping - support user and group search base

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: common, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      org.apache.hadoop.security.LdapGroupsMapping currently supports hadoop.security.group.mapping.ldap.base as search base for both user and group searches. However, this doesn't work when user and group search bases are different like ou=Users,dc=xxx,dc=com and ou=Groups,dc=xxx,dc=com.

      Expose different configs for user and group search base which defaults to the existing hadoop.security.group.mapping.ldap.base config

      1. 0001-HADOOP-14465-LdapGroupsMapping-support-user-and-grou.patch
        10 kB
        Shwetha G S
      2. HADOOP-14465-v2.patch
        9 kB
        Shwetha G S
      3. HADOOP-14465-v4.patch
        11 kB
        Shwetha G S
      4. HADOOP-14465-v5.patch
        11 kB
        Mingliang Liu

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11854 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11854/)
        HADOOP-14465. LdapGroupsMapping - support user and group search base. (liuml07: rev a2121cb0d907be439d19cd1165a0371b37a5fe68)

        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/GroupsMapping.md
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11854 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11854/ ) HADOOP-14465 . LdapGroupsMapping - support user and group search base. (liuml07: rev a2121cb0d907be439d19cd1165a0371b37a5fe68) (edit) hadoop-common-project/hadoop-common/src/site/markdown/GroupsMapping.md (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Committed to trunk and branch-2 branches. Thanks Shwetha G S for your contribution. Thanks Jitendra Nath Pandey and Steve Loughran for review and discussion.

        Show
        liuml07 Mingliang Liu added a comment - Committed to trunk and branch-2 branches. Thanks Shwetha G S for your contribution. Thanks Jitendra Nath Pandey and Steve Loughran for review and discussion.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 21s trunk passed
        +1 compile 14m 4s trunk passed
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 1m 4s trunk passed
        -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 50s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 10m 59s the patch passed
        +1 javac 10m 59s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 3s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 51s the patch passed
        +1 unit 7m 56s hadoop-common in the patch passed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        58m 39s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14465
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872354/HADOOP-14465-v5.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 3eb0bc8fd42b 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5578af8
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12509/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12509/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12509/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 21s trunk passed +1 compile 14m 4s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 4s trunk passed -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 50s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 10m 59s the patch passed +1 javac 10m 59s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 51s the patch passed +1 unit 7m 56s hadoop-common in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 58m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14465 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872354/HADOOP-14465-v5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 3eb0bc8fd42b 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5578af8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12509/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12509/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12509/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        +1 for the latest patch.

        Show
        jnp Jitendra Nath Pandey added a comment - +1 for the latest patch.
        Hide
        liuml07 Mingliang Liu added a comment -

        I upload the v5 patch addressing all my own comments above. I'm still +1 on the patch. But it's good to have a second opinion before commit. Jitendra Nath Pandey do you have time to review? Thanks,

        Show
        liuml07 Mingliang Liu added a comment - I upload the v5 patch addressing all my own comments above. I'm still +1 on the patch. But it's good to have a second opinion before commit. Jitendra Nath Pandey do you have time to review? Thanks,
        Hide
        liuml07 Mingliang Liu added a comment -

        +1

        Minor comments:

        1. By

          use getTrimmed() to strip off whitespace.

          I think Steve was saying

          userbaseDN = conf.get(USER_BASE_DN_KEY, baseDN).trim();
          

          to be replaced with

          userbaseDN = conf.getTrimmed(USER_BASE_DN_KEY, baseDN);
          

          The first will work though I think.

        2. The two test code may be reused by creating a helper method: private void testGetGroupsWithBaseDN(Configuration conf, String userBaseDN, String groupBaseDN).
        Show
        liuml07 Mingliang Liu added a comment - +1 Minor comments: By use getTrimmed() to strip off whitespace. I think Steve was saying userbaseDN = conf.get(USER_BASE_DN_KEY, baseDN).trim(); to be replaced with userbaseDN = conf.getTrimmed(USER_BASE_DN_KEY, baseDN); The first will work though I think. The two test code may be reused by creating a helper method: private void testGetGroupsWithBaseDN(Configuration conf, String userBaseDN, String groupBaseDN) .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 15m 7s trunk passed
        +1 compile 15m 10s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 6s trunk passed
        -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 42s the patch passed
        +1 compile 10m 6s the patch passed
        +1 javac 10m 6s the patch passed
        +1 checkstyle 0m 36s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 50s the patch passed
        +1 unit 7m 56s hadoop-common in the patch passed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        59m 40s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14465
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872197/HADOOP-14465-v4.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 24dec41f7cea 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7c9694c
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12493/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12493/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12493/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 15m 7s trunk passed +1 compile 15m 10s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 6s trunk passed -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 10m 6s the patch passed +1 javac 10m 6s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 7m 56s hadoop-common in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 59m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14465 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872197/HADOOP-14465-v4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 24dec41f7cea 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7c9694c Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12493/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12493/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12493/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        shwethags Shwetha G S added a comment -

        Steve Loughran, the latest patch addresses all the review comments. Trimming the config values should have ideally gone into config.get()

        Show
        shwethags Shwetha G S added a comment - Steve Loughran , the latest patch addresses all the review comments. Trimming the config values should have ideally gone into config.get()
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Minor details; I don't know enough about LDAP to actually cover the core functionality

        LdapGroupsMapping

        • use getTrimmed() to strip off whitespace.
        • how about logging @ debug the values (line 602+), now that resolution is more complex
        • you need a "." at the end of your javadoc comments: Java 8 javadoc complains otherwise.

        GroupsMapping.md: use ` ` quotes around configuration keys in the docs to have them fixed font.

        TestLdapGroupsMapping: can you (somehow) add a regression test which verifies that if only BASE_DN_KEY is set, that still gets picked up. There's no test working with that option as far as my IDE can tell.

        Show
        stevel@apache.org Steve Loughran added a comment - Minor details; I don't know enough about LDAP to actually cover the core functionality LdapGroupsMapping use getTrimmed() to strip off whitespace. how about logging @ debug the values (line 602+), now that resolution is more complex you need a "." at the end of your javadoc comments: Java 8 javadoc complains otherwise. GroupsMapping.md : use ` ` quotes around configuration keys in the docs to have them fixed font. TestLdapGroupsMapping : can you (somehow) add a regression test which verifies that if only BASE_DN_KEY is set, that still gets picked up. There's no test working with that option as far as my IDE can tell.
        Hide
        shwethags Shwetha G S added a comment -

        The test failure hadoop.fs.sftp.TestSFTPFileSystem doesn't look related to the patch and it worked on my local machine. Even findbugs issues are un-related to the patch

        Show
        shwethags Shwetha G S added a comment - The test failure hadoop.fs.sftp.TestSFTPFileSystem doesn't look related to the patch and it worked on my local machine. Even findbugs issues are un-related to the patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 38s trunk passed
        +1 compile 14m 25s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 7s trunk passed
        -1 findbugs 1m 29s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 51s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 10m 41s the patch passed
        +1 javac 10m 41s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 5s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 1m 36s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 7m 47s hadoop-common in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        58m 9s



        Reason Tests
        Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14465
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872007/HADOOP-14465-v2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 4e4583f64c9b 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5672ae7
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 38s trunk passed +1 compile 14m 25s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 7s trunk passed -1 findbugs 1m 29s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 10m 41s the patch passed +1 javac 10m 41s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 7m 47s hadoop-common in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 58m 9s Reason Tests Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14465 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872007/HADOOP-14465-v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 4e4583f64c9b 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5672ae7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12478/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        shwethags Shwetha G S added a comment -

        Jitendra Nath Pandey, I have fixed the review comments and the checkstyle issues

        Show
        shwethags Shwetha G S added a comment - Jitendra Nath Pandey , I have fixed the review comments and the checkstyle issues
        Hide
        jnp Jitendra Nath Pandey added a comment -

        Minor nits & style:
        Please make SEARCH_CONTROLS package private.
        In the test filterExpr argument is very long, please split it into two lines.

        The patch functionally looks fine to me.

        Show
        jnp Jitendra Nath Pandey added a comment - Minor nits & style: Please make SEARCH_CONTROLS package private. In the test filterExpr argument is very long, please split it into two lines. The patch functionally looks fine to me.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 28s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 2s trunk passed
        +1 compile 13m 19s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        -1 findbugs 1m 22s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 12m 51s the patch passed
        +1 javac 12m 51s the patch passed
        -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 3 new + 32 unchanged - 0 fixed = 35 total (was 32)
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 7m 37s hadoop-common in the patch passed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        58m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14465
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870303/0001-HADOOP-14465-LdapGroupsMapping-support-user-and-grou.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 25eaf0613ee3 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a7f085d
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 2s trunk passed +1 compile 13m 19s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 17s trunk passed -1 findbugs 1m 22s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 12m 51s the patch passed +1 javac 12m 51s the patch passed -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 3 new + 32 unchanged - 0 fixed = 35 total (was 32) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 7m 37s hadoop-common in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 58m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14465 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870303/0001-HADOOP-14465-LdapGroupsMapping-support-user-and-grou.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 25eaf0613ee3 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a7f085d Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12412/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            shwethags Shwetha G S
            Reporter:
            shwethags Shwetha G S
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development