[HADOOP-14434] Use MoveFileEx to allow renaming a file when the destination exists

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.1, 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2
• Fix Version/s: 2.7.4, 3.0.0-alpha4
• Component/s: native
• Labels: windows
• Hadoop Flags: Reviewed
• Assignee: Lukas Majercak
• Reporter: Lukas Majercak
• Created: 27/Apr/17 21:17
• Updated: 05/Jun/18 20:41
• Resolved: 18/May/17 00:32

Description

The NativeIO.c#renameTo0 currently uses MoveFile Windows system call, which fails when renaming a file to a destination that already exists.

This makes the TestRollingUpgrade.testRollback test fail on Windows, as during that execution, a DataNode tries to rename block's meta file to a destination that exists.

The proposal is to change to using MoveFileEx Windows call, and passing in MOVEFILE_REPLACE_EXISTING flag to force the renaming.

Issue Links

• is broken by: HADOOP-9437 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException
• is related to: HADOOP-12550 NativeIO#renameTo on Windows cannot replace an existing file at the destination.