[HADOOP-14429] FTPFileSystem#getFsAction always returns FsAction.NONE

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Component/s: fs
• Hadoop Flags: Reviewed
• Assignee: Hongyuan Li
• Reporter: Hongyuan Li
• Created: 17/May/17 02:11
• Updated: 04/Jul/17 11:58
• Resolved: 21/Jun/17 00:30

Description

private FsAction getFsAction(int accessGroup, FTPFile ftpFile) {
      FsAction action = FsAction.NONE;
      if (ftpFile.hasPermission(accessGroup, FTPFile.READ_PERMISSION)) {
      action.or(FsAction.READ);
  }
    if (ftpFile.hasPermission(accessGroup, FTPFile.WRITE_PERMISSION)) {
      action.or(FsAction.WRITE);
    }
    if (ftpFile.hasPermission(accessGroup, FTPFile.EXECUTE_PERMISSION)) {
      action.or(FsAction.EXECUTE);
    }
    return action;
  }

from code above, we can see that the getFsAction method doesnot modify the action generated by FsAction action = FsAction.NONE,which means it return FsAction.NONE all the time;

Issue Links

• is required by: HADOOP-14469 FTPFileSystem#listStatus get currentPath and parentPath at the same time, causing recursively list action endless
• is required by: HADOOP-14559 FTPFileSystem instance in TestFTPFileSystem should be created before tests and closed after tests