Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14415

Use java.lang.AssertionError instead of junit.framework.AssertionFailedError

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: None
    • Labels:

      Description

      When reviewing HADOOP-14180, I found some test codes throw junit.framework.AssertionFailedError. org.junit.Assert no longer throws AssertionFailedError, so we should use AssertionError instead of AssertionFailedError.

        Issue Links

          Activity

          Hide
          vagarychen Chen Liang added a comment -

          Post v001 patch to replace AssertionFailedError with AssertionError

          Show
          vagarychen Chen Liang added a comment - Post v001 patch to replace AssertionFailedError with AssertionError
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 15m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 12m 1s trunk passed
          +1 compile 12m 33s trunk passed
          +1 checkstyle 1m 39s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 31s trunk passed
          -1 findbugs 1m 21s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 0s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 0m 54s the patch passed
          +1 compile 12m 4s the patch passed
          +1 javac 12m 4s the patch passed
          +1 checkstyle 1m 50s the patch passed
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 1m 5s the patch passed
          -1 unit 7m 19s hadoop-common in the patch failed.
          +1 unit 0m 27s hadoop-openstack in the patch passed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          98m 4s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14415
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868123/HADOOP-14415.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 044492f98db6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c48f297
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 15m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 12m 1s trunk passed +1 compile 12m 33s trunk passed +1 checkstyle 1m 39s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 31s trunk passed -1 findbugs 1m 21s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 0s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 12m 4s the patch passed +1 javac 12m 4s the patch passed +1 checkstyle 1m 50s the patch passed +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 1m 5s the patch passed -1 unit 7m 19s hadoop-common in the patch failed. +1 unit 0m 27s hadoop-openstack in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 98m 4s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14415 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868123/HADOOP-14415.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 044492f98db6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c48f297 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12315/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vagarychen Chen Liang added a comment -

          The failed test and the findbug warnings are unrelated.

          Show
          vagarychen Chen Liang added a comment - The failed test and the findbug warnings are unrelated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Chen Liang for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Chen Liang for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11744 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11744/)
          HADOOP-14415. Use java.lang.AssertionError instead of (aajisaka: rev d4aa9e3c699f6a584ed020851189a81f825ce915)

          • (edit) hadoop-tools/hadoop-openstack/src/test/java/org/apache/hadoop/fs/swift/TestSwiftFileSystemContract.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11744 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11744/ ) HADOOP-14415 . Use java.lang.AssertionError instead of (aajisaka: rev d4aa9e3c699f6a584ed020851189a81f825ce915) (edit) hadoop-tools/hadoop-openstack/src/test/java/org/apache/hadoop/fs/swift/TestSwiftFileSystemContract.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java

            People

            • Assignee:
              vagarychen Chen Liang
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development