[HADOOP-14388] Don't set the key password if there is a problem reading SSL configuration

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.8.0, 2.7.3
• Target Version/s: 2.7.8
• Assignee: Colm O hEigeartaigh
• Reporter: Colm O hEigeartaigh
• Created: 05/May/17 11:48
• Updated: 02/Jun/18 17:40

Description

When launching MiniDFSCluster in a test, with "dfs.data.transfer.protection=integrity" and without specifying a ssl-server.xml, the code hangs on "builder.build()".

This is because in HttpServer2, it is setting a null value on the SslSocketConnector:

c.setKeyPassword(keyPassword);

Instead, this call should be inside the "if (keystore != null) {" block. Once this is done the code exits as expected with an error.