Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14375

Remove tomcat support from hadoop-functions.sh

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: scripts
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      This change removes the support in the shell scripts for Tomcat that was added in 3.0.0-alpha1.

      Description

      Now that tomcat is no longer needed by Hadoop, let's rip out the awful tomcat shell functions.

        Issue Links

          Activity

          Hide
          jzhuge John Zhuge added a comment -

          Thanks Akira Ajisaka for the review and commit. Thanks Allen Wittenauer for reporting the issue and the review.

          Show
          jzhuge John Zhuge added a comment - Thanks Akira Ajisaka for the review and commit. Thanks Allen Wittenauer for reporting the issue and the review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11729 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11729/)
          HADOOP-14375. Remove tomcat support from hadoop-functions.sh. (aajisaka: rev a9e24a13b7e3cdd92898d39ec5bf03382336e597)

          • (delete) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_finalize_catalina_opts.bats
          • (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11729 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11729/ ) HADOOP-14375 . Remove tomcat support from hadoop-functions.sh. (aajisaka: rev a9e24a13b7e3cdd92898d39ec5bf03382336e597) (delete) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_finalize_catalina_opts.bats (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks John Zhuge for the contribution and thanks Allen Wittenauer for the review!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks John Zhuge for the contribution and thanks Allen Wittenauer for the review!
          Hide
          aw Allen Wittenauer added a comment -

          +1

          Show
          aw Allen Wittenauer added a comment - +1
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Thanks Allen Wittenauer and John Zhuge.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Thanks Allen Wittenauer and John Zhuge .
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 13m 27s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvnsite 0m 58s the patch passed
          +1 shellcheck 2m 37s There were no new shellcheck issues.
          +1 shelldocs 0m 8s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 1m 58s hadoop-common in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          21m 10s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14375
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867143/HADOOP-14375.001.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 4802ef7d7391 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 45382bf
          shellcheck v0.4.6
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12283/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12283/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 27s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvnsite 0m 58s the patch passed +1 shellcheck 2m 37s There were no new shellcheck issues. +1 shelldocs 0m 8s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 58s hadoop-common in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 21m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14375 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867143/HADOOP-14375.001.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 4802ef7d7391 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 45382bf shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12283/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12283/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 001

          • Remove hadoop_finalize_catalina_opts

          Testing done

          • Passed shelltest in hadoop-common
          Show
          jzhuge John Zhuge added a comment - Patch 001 Remove hadoop_finalize_catalina_opts Testing done Passed shelltest in hadoop-common

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development