Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha4, 2.8.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      license is not at the top of the class.

      1. HADOOP-14374.001.patch
        3 kB
        lixinglong
      2. HADOOP-14374.002.patch
        3 kB
        lixinglong
      3. HADOOP-14374.003.patch
        3 kB
        lixinglong

        Activity

        Hide
        lixinglong lixinglong added a comment -

        license is not at the top of the class.

        Show
        lixinglong lixinglong added a comment - license is not at the top of the class.
        Hide
        lixinglong lixinglong added a comment -

        Akira Ajisaka Thanks for your comments !

        Show
        lixinglong lixinglong added a comment - Akira Ajisaka Thanks for your comments !
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 31s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 21s trunk passed
        -1 findbugs 0m 31s hadoop-tools/hadoop-gridmix in trunk has 2 extant Findbugs warnings.
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 21s the patch passed
        +1 javac 0m 21s the patch passed
        -0 checkstyle 0m 11s hadoop-tools/hadoop-gridmix: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 37s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 14m 25s hadoop-gridmix in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        35m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14374
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866830/HADOOP-14374.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fb5b239d328d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a9a3d21
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-gridmix-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-gridmix.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/testReport/
        modules C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 31s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 21s trunk passed -1 findbugs 0m 31s hadoop-tools/hadoop-gridmix in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed -0 checkstyle 0m 11s hadoop-tools/hadoop-gridmix: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 14m 25s hadoop-gridmix in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 35m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14374 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866830/HADOOP-14374.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fb5b239d328d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a9a3d21 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-gridmix-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-gridmix.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/testReport/ modules C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12262/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 26s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 41s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 20s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        -1 findbugs 0m 28s hadoop-tools/hadoop-gridmix in trunk has 2 extant Findbugs warnings.
        +1 javadoc 0m 13s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 33s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 13m 57s hadoop-gridmix in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        33m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14374
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866858/HADOOP-14374.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4ae258c4ae04 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a9a3d21
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12265/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-gridmix-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12265/testReport/
        modules C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12265/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 41s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 0m 17s trunk passed -1 findbugs 0m 28s hadoop-tools/hadoop-gridmix in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 33s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 13m 57s hadoop-gridmix in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 33m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14374 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866858/HADOOP-14374.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4ae258c4ae04 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a9a3d21 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12265/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-gridmix-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12265/testReport/ modules C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12265/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, checking this in.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, branch-2.8, branch-2.8.1, and branch-2.7. Thanks lixinglong for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, branch-2.8.1, and branch-2.7. Thanks lixinglong for the contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11702 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11702/)
        HADOOP-14374. License error in GridmixTestUtils.java. Contributed by (aajisaka: rev c60164fb60d3d8afb0fb8410936ccc231c4593f9)

        • (edit) hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/GridmixTestUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11702 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11702/ ) HADOOP-14374 . License error in GridmixTestUtils.java. Contributed by (aajisaka: rev c60164fb60d3d8afb0fb8410936ccc231c4593f9) (edit) hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/GridmixTestUtils.java
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          People

          • Assignee:
            lixinglong lixinglong
            Reporter:
            lixinglong lixinglong
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development