Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14359

Remove unnecessary shading of commons-httpclient

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None

      Description

      commons-httpclient dependency was removed in HADOOP-10105 but there are some settings to shade commons-httpclient. Probably they can be safely removed.

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Assign this to myself. I'd like to get rid of commons-httpclient and make downstream applications aware it will no longer appear in Hadoop code.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Assign this to myself. I'd like to get rid of commons-httpclient and make downstream applications aware it will no longer appear in Hadoop code.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Here's a quick patch to remove commons-httpclient from all pom.xml. It compiles locally.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Here's a quick patch to remove commons-httpclient from all pom.xml. It compiles locally.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, the patch looks good to me. I confirmed that the modules do not have transitive commons-httpclient dependency.

          I'd like to get rid of commons-httpclient and make downstream applications aware it will no longer appear in Hadoop code.

          Unfortunately, not yet. Now hadoop-yarn-project and yarn-server-timelineserver-hbase module have transitive commons-httpclient dependency via hbase-server.

          • hadoop-yarn-project -> hadoop-yarn-server -> hbase-server:1.2.4 -> commons-httpclient:3.1.0

          HBASE-16267 removed the dependency and the fix version is 2.0.0.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, the patch looks good to me. I confirmed that the modules do not have transitive commons-httpclient dependency. I'd like to get rid of commons-httpclient and make downstream applications aware it will no longer appear in Hadoop code. Unfortunately, not yet. Now hadoop-yarn-project and yarn-server-timelineserver-hbase module have transitive commons-httpclient dependency via hbase-server. hadoop-yarn-project -> hadoop-yarn-server -> hbase-server:1.2.4 -> commons-httpclient:3.1.0 HBASE-16267 removed the dependency and the fix version is 2.0.0.
          Hide
          jojochuang Wei-Chiu Chuang added a comment - - edited

          Thanks for the pointer!
          I really wish we could get rid of commons-httpclient in Hadoop 3.

          ran mvn dependency:tree and I see commons-httpclient 3 is exposed in two jars:

          [INFO] org.apache.hadoop:hadoop-yarn-server-timelineservice-hbase:jar:3.0.0-alpha3-SNAPSHOT
          [INFO] +- org.apache.hbase:hbase-server:jar:1.2.4:compile
          [INFO] | +- org.apache.hbase:hbase-procedure:jar:1.2.4:compile
          [INFO] | | - org.apache.hbase:hbase-common:jar:tests:1.2.4:test
          [INFO] | +- org.apache.hbase:hbase-prefix-tree:jar:1.2.4:runtime
          [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile

          [INFO] org.apache.hadoop:hadoop-yarn-server-timelineservice-hbase-tests:jar:3.0.0-alpha3-SNAPSHOT
          [INFO] +- org.apache.hbase:hbase-server:jar:1.2.4:compile
          [INFO] | +- org.apache.hbase:hbase-procedure:jar:1.2.4:compile
          [INFO] | | - org.apache.hbase:hbase-common:jar:tests:1.2.4:test
          [INFO] | +- org.apache.hbase:hbase-prefix-tree:jar:1.2.4:runtime
          [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile

          Show
          jojochuang Wei-Chiu Chuang added a comment - - edited Thanks for the pointer! I really wish we could get rid of commons-httpclient in Hadoop 3. ran mvn dependency:tree and I see commons-httpclient 3 is exposed in two jars: [INFO] org.apache.hadoop:hadoop-yarn-server-timelineservice-hbase:jar:3.0.0-alpha3-SNAPSHOT [INFO] +- org.apache.hbase:hbase-server:jar:1.2.4:compile [INFO] | +- org.apache.hbase:hbase-procedure:jar:1.2.4:compile [INFO] | | - org.apache.hbase:hbase-common:jar:tests:1.2.4:test [INFO] | +- org.apache.hbase:hbase-prefix-tree:jar:1.2.4:runtime [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile [INFO] org.apache.hadoop:hadoop-yarn-server-timelineservice-hbase-tests:jar:3.0.0-alpha3-SNAPSHOT [INFO] +- org.apache.hbase:hbase-server:jar:1.2.4:compile [INFO] | +- org.apache.hbase:hbase-procedure:jar:1.2.4:compile [INFO] | | - org.apache.hbase:hbase-common:jar:tests:1.2.4:test [INFO] | +- org.apache.hbase:hbase-prefix-tree:jar:1.2.4:runtime [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 13m 26s trunk passed
          +1 compile 16m 21s trunk passed
          +1 mvnsite 2m 10s trunk passed
          +1 mvneclipse 1m 14s trunk passed
          +1 javadoc 1m 14s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 3m 49s the patch passed
          +1 compile 14m 9s the patch passed
          +1 javac 14m 9s the patch passed
          +1 mvnsite 2m 5s the patch passed
          +1 mvneclipse 1m 4s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 4s The patch has no ill-formed XML file.
          +1 javadoc 0m 48s the patch passed
          +1 unit 2m 51s hadoop-kms in the patch passed.
          +1 unit 3m 40s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 0m 20s hadoop-client-minicluster in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          66m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-14359
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865384/HADOOP-14359.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 0e993185e9c1 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8a3309
          Default Java 1.8.0_121
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12202/testReport/
          modules C: hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client-minicluster U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12202/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 13m 26s trunk passed +1 compile 16m 21s trunk passed +1 mvnsite 2m 10s trunk passed +1 mvneclipse 1m 14s trunk passed +1 javadoc 1m 14s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 3m 49s the patch passed +1 compile 14m 9s the patch passed +1 javac 14m 9s the patch passed +1 mvnsite 2m 5s the patch passed +1 mvneclipse 1m 4s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 4s The patch has no ill-formed XML file. +1 javadoc 0m 48s the patch passed +1 unit 2m 51s hadoop-kms in the patch passed. +1 unit 3m 40s hadoop-hdfs-httpfs in the patch passed. +1 unit 0m 20s hadoop-client-minicluster in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 66m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-14359 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865384/HADOOP-14359.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 0e993185e9c1 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8a3309 Default Java 1.8.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12202/testReport/ modules C: hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client-minicluster U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12202/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Wei-Chiu Chuang for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Wei-Chiu Chuang for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11655 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11655/)
          HADOOP-14359. Remove unnecessary shading of commons-httpclient. (aajisaka: rev b7d769d02002c2101cc157500732f1f8d8dbd5da)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
          • (edit) hadoop-client-modules/hadoop-client-minicluster/pom.xml
          • (edit) hadoop-common-project/hadoop-kms/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11655 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11655/ ) HADOOP-14359 . Remove unnecessary shading of commons-httpclient. (aajisaka: rev b7d769d02002c2101cc157500732f1f8d8dbd5da) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml (edit) hadoop-client-modules/hadoop-client-minicluster/pom.xml (edit) hadoop-common-project/hadoop-kms/pom.xml

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development