Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14320

TestIPC.testIpcWithReaderQueuing fails intermittently

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-alpha4, 2.8.2
    • None
    • None

    Description

      org.mockito.exceptions.verification.TooLittleActualInvocations: 
      callQueueManager.put(<any>);
      Wanted 2 times:
      -> at org.apache.hadoop.ipc.TestIPC.checkBlocking(TestIPC.java:810)
      But was 1 time:
      -> at org.apache.hadoop.ipc.Server.queueCall(Server.java:2466)
      
      	at org.apache.hadoop.ipc.TestIPC.checkBlocking(TestIPC.java:810)
      	at org.apache.hadoop.ipc.TestIPC.testIpcWithReaderQueuing(TestIPC.java:738)
      

      Attachments

        1. HADOOP-14320.001.patch
          0.8 kB
          Eric Badger

        Activity

          ebadger Eric Badger added a comment -

          TestIPC.java:810
          verify(spy, timeout(100).times(i + 1)).put(Mockito.<Call>anyObject());
          The 100ms timeout is too aggressive. If the threads don't start immediately or run more slowly than this main-line code (aka doesn't finish its call in 100ms), the timeout will cause the test to fail. This can be recreated by adding a 150ms timeout to the thread's run method.

          ebadger Eric Badger added a comment - TestIPC.java:810 verify(spy, timeout(100).times(i + 1)).put(Mockito.<Call>anyObject()); The 100ms timeout is too aggressive. If the threads don't start immediately or run more slowly than this main-line code (aka doesn't finish its call in 100ms), the timeout will cause the test to fail. This can be recreated by adding a 150ms timeout to the thread's run method.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 15m 25s trunk passed
          +1 compile 19m 42s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 14s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 findbugs 1m 46s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 15m 11s the patch passed
          +1 javac 15m 11s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 34s the patch passed
          +1 javadoc 0m 48s the patch passed
          -1 unit 8m 14s hadoop-common in the patch failed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          71m 33s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-14320
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863842/HADOOP-14320.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d0a3db3b5d8a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 654372d
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12119/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12119/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12119/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 15m 25s trunk passed +1 compile 19m 42s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 15m 11s the patch passed +1 javac 15m 11s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 48s the patch passed -1 unit 8m 14s hadoop-common in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 71m 33s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-14320 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863842/HADOOP-14320.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d0a3db3b5d8a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 654372d Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12119/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12119/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12119/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          epayne Eric Payne added a comment -

          Thanks ebadger.
          +1

          epayne Eric Payne added a comment - Thanks ebadger . +1
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11650 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11650/)
          HADOOP-14320. TestIPC.testIpcWithReaderQueuing fails intermittently. (epayne: rev 6fe11f61556407f8efb9b376623cd61609a40d5f)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11650 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11650/ ) HADOOP-14320 . TestIPC.testIpcWithReaderQueuing fails intermittently. (epayne: rev 6fe11f61556407f8efb9b376623cd61609a40d5f) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java

          People

            ebadger Eric Badger
            ebadger Eric Badger
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: