Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14293

Initialize FakeTimer with a less trivial value

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha4, 2.8.2
    • Component/s: test
    • Labels:
      None

      Description

      HADOOP-14276 broke TestFsDatasetImpl#testLoadingDfsUsedForVolumes which uses a FakeTimer.

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          Seems to work again when I changed the start time back up.

          Show
          andrew.wang Andrew Wang added a comment - Seems to work again when I changed the start time back up.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 50s trunk passed
          +1 compile 14m 40s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 1m 26s trunk passed
          +1 javadoc 0m 48s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 13m 27s the patch passed
          +1 javac 13m 27s the patch passed
          +1 checkstyle 0m 35s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 33s the patch passed
          +1 javadoc 0m 50s the patch passed
          -1 unit 7m 48s hadoop-common in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          60m 47s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-14293
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862542/HADOOP-14293.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 62fe22db7f80 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e8bdad7
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12065/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12065/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12065/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 50s trunk passed +1 compile 14m 40s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 13m 27s the patch passed +1 javac 13m 27s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 50s the patch passed -1 unit 7m 48s hadoop-common in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 60m 47s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14293 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862542/HADOOP-14293.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 62fe22db7f80 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e8bdad7 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12065/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12065/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12065/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - +1
          Hide
          xkrogen Erik Krogen added a comment -

          Interesting... Can't quite tell why the change broke this test but thank you for catching it, Andrew Wang!

          Show
          xkrogen Erik Krogen added a comment - Interesting... Can't quite tell why the change broke this test but thank you for catching it, Andrew Wang !
          Hide
          andrew.wang Andrew Wang added a comment -

          Committed down through 2.7, thanks for reviewing Steve, Erik!

          Show
          andrew.wang Andrew Wang added a comment - Committed down through 2.7, thanks for reviewing Steve, Erik!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11561 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11561/)
          HADOOP-14293. Initialize FakeTimer with a less trivial value. (wang: rev be144117a885cb39bc192279c96cbe3790dc77b1)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11561 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11561/ ) HADOOP-14293 . Initialize FakeTimer with a less trivial value. (wang: rev be144117a885cb39bc192279c96cbe3790dc77b1) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
          HADOOP-14293. Initialize FakeTimer with a less trivial value. (wang: rev be144117a885cb39bc192279c96cbe3790dc77b1)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) HADOOP-14293 . Initialize FakeTimer with a less trivial value. (wang: rev be144117a885cb39bc192279c96cbe3790dc77b1) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

            People

            • Assignee:
              andrew.wang Andrew Wang
              Reporter:
              andrew.wang Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development