Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: fs/azure
    • Labels:
      None

      Description

      This improvement seeks to simplify the WASB-Ranger policy model – both the policy specification and policy enforcement.
      More specifically, WASB-Ranger checks do not follow the same policy model and enforcement as Ranger-HDFS.

      Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The handoff requires the Ranger policies follow the same model as HDFS-ACLs. This is not true with Ranger+WASB.

      We seek to simplify the policy specification and enforcement by dropping the 'x' bit altogether.

      This JIRA tracks this improvement, alongwith a few more minor bugfixes that were found during Ranger-WASB testing.

      1. HADOOP-14274.002.patch
        51 kB
        Sivaguru Sankaridurg
      2. HADOOP-14274.003.patch
        52 kB
        Sivaguru Sankaridurg
      3. HADOOP-14274-001.patch
        51 kB
        Sivaguru Sankaridurg
      4. TestingForRegressionWithSecureModeSwitchedOff.txt
        15 kB
        Sivaguru Sankaridurg
      5. TestingWithSecureModeSwitchedOnSuccess.txt
        35 kB
        Sivaguru Sankaridurg

        Activity

        Hide
        liuml07 Mingliang Liu added a comment -

        Sivaguru Sankaridurg can you add releases notes for this JIRA? That should summarize major changes, and be helpful for others to get the context. Thanks,

        Show
        liuml07 Mingliang Liu added a comment - Sivaguru Sankaridurg can you add releases notes for this JIRA? That should summarize major changes, and be helpful for others to get the context. Thanks,
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
        HADOOP-14274. Azure: Simplify Ranger-WASB policy model. Contributed by (liuml07: rev 0cab57223e3f54be17a5f27cefdb6d1da1b073e5)

        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockWasbAuthorizerImpl.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java
        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbAuthorizationOperations.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbRemoteCallHelper.java
        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteWasbAuthorizerImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) HADOOP-14274 . Azure: Simplify Ranger-WASB policy model. Contributed by (liuml07: rev 0cab57223e3f54be17a5f27cefdb6d1da1b073e5) (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockWasbAuthorizerImpl.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbAuthorizationOperations.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbRemoteCallHelper.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteWasbAuthorizerImpl.java
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Thanks for reviewing and committing Mingliang Liu.

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Thanks for reviewing and committing Mingliang Liu .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11584 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11584/)
        HADOOP-14274. Azure: Simplify Ranger-WASB policy model. Contributed by (liuml07: rev 0cab57223e3f54be17a5f27cefdb6d1da1b073e5)

        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockWasbAuthorizerImpl.java
        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteWasbAuthorizerImpl.java
        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbAuthorizationOperations.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbRemoteCallHelper.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11584 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11584/ ) HADOOP-14274 . Azure: Simplify Ranger-WASB policy model. Contributed by (liuml07: rev 0cab57223e3f54be17a5f27cefdb6d1da1b073e5) (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockWasbAuthorizerImpl.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteWasbAuthorizerImpl.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbAuthorizationOperations.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbRemoteCallHelper.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Committed to branch-2 and trunk branches. Thanks Sivaguru Sankaridurg, for the patch, and testing!

        Show
        liuml07 Mingliang Liu added a comment - Committed to branch-2 and trunk branches. Thanks Sivaguru Sankaridurg , for the patch, and testing!
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        0 patch 0m 4s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 13m 30s trunk passed
        +1 compile 0m 22s trunk passed
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 0m 31s trunk passed
        +1 javadoc 0m 17s trunk passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 17s the patch passed
        +1 javac 0m 17s the patch passed
        -0 checkstyle 0m 13s hadoop-tools/hadoop-azure: The patch generated 1 new + 54 unchanged - 1 fixed = 55 total (was 55)
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 shellcheck 2m 35s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
        +1 shelldocs 0m 10s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 0m 34s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 1m 18s hadoop-azure in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        23m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:612578f
        JIRA Issue HADOOP-14274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863003/TestingWithSecureModeSwitchedOnSuccess.txt
        Optional Tests asflicense unit shellcheck shelldocs compile javac javadoc mvninstall mvnsite findbugs checkstyle xml
        uname Linux 5c5d8cf1864b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f48e968
        Default Java 1.8.0_121
        shellcheck v0.4.6
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12087/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12087/testReport/
        modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12087/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. 0 patch 0m 4s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 30s trunk passed +1 compile 0m 22s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed -0 checkstyle 0m 13s hadoop-tools/hadoop-azure: The patch generated 1 new + 54 unchanged - 1 fixed = 55 total (was 55) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 13s the patch passed +1 shellcheck 2m 35s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 1m 18s hadoop-azure in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 23m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:612578f JIRA Issue HADOOP-14274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863003/TestingWithSecureModeSwitchedOnSuccess.txt Optional Tests asflicense unit shellcheck shelldocs compile javac javadoc mvninstall mvnsite findbugs checkstyle xml uname Linux 5c5d8cf1864b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f48e968 Default Java 1.8.0_121 shellcheck v0.4.6 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12087/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12087/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12087/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Hi Mingliang Liu,

        I have attached HADOOP-14274.003.patch with a minor fix to one of the tests.
        I have also attached logs that indicate that there was no regression, and that the new functionality passed all tests.
        I hope this is what you were looking for.

        Thanks
        Siva

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Hi Mingliang Liu , I have attached HADOOP-14274 .003.patch with a minor fix to one of the tests. I have also attached logs that indicate that there was no regression, and that the new functionality passed all tests. I hope this is what you were looking for. Thanks Siva
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Logs to show that all tests passed when authorization was turned on

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Logs to show that all tests passed when authorization was turned on
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Logs to show that there was no regression on account of these changes when authorization was turned off

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Logs to show that there was no regression on account of these changes when authorization was turned off
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Minor fix to Instrumentation related tests

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Minor fix to Instrumentation related tests
        Hide
        liuml07 Mingliang Liu added a comment -

        The checkstyle warning is fine to skip in this patch.

        How about the testing?

        Show
        liuml07 Mingliang Liu added a comment - The checkstyle warning is fine to skip in this patch. How about the testing?
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Mingliang Liu. I fixed all your code review comments in the latest patch. Please review the changes.
        I have not broken up NativeAzureFileSystem.java into smaller file. That is the only checkstyle item still pending. I'll fix it in future changes.

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Mingliang Liu . I fixed all your code review comments in the latest patch. Please review the changes. I have not broken up NativeAzureFileSystem.java into smaller file. That is the only checkstyle item still pending. I'll fix it in future changes.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 13m 13s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 20s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        -0 checkstyle 0m 11s hadoop-tools/hadoop-azure: The patch generated 1 new + 42 unchanged - 7 fixed = 43 total (was 49)
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 32s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 1m 17s hadoop-azure in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        20m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:612578f
        JIRA Issue HADOOP-14274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862834/HADOOP-14274.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 51542d6074b9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / aabf08d
        Default Java 1.8.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/testReport/
        modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 13m 13s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -0 checkstyle 0m 11s hadoop-tools/hadoop-azure: The patch generated 1 new + 42 unchanged - 7 fixed = 43 total (was 49) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 1m 17s hadoop-azure in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 20m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:612578f JIRA Issue HADOOP-14274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862834/HADOOP-14274.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 51542d6074b9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aabf08d Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Addressed Ming Liang's code review comments on 06-Apr-2017

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Addressed Ming Liang's code review comments on 06-Apr-2017
        Hide
        liuml07 Mingliang Liu added a comment -

        Overall looks good.

        1. performAuthCheck should have javadoc for all parameters.
        2. Checkstyle warnings are related.
        3. As we're changing performAuthCheck, is it possible to use WasbAuthorizationOperations accessType instead of String accessType as parameter of [{private void performAuthCheck()}}? This seems cleaner.
        4. MockWasbAuthorizerImpl.java:66, let's use Map.Entry<> instead of HashMap.Entry<>. We should always use the interface type unless we have good reasons. Plus, this fails in Java 7 as the HashMap.Entry is private.

        Testing will happen and let's post test report here before commit.

        Show
        liuml07 Mingliang Liu added a comment - Overall looks good. performAuthCheck should have javadoc for all parameters. Checkstyle warnings are related. As we're changing performAuthCheck , is it possible to use WasbAuthorizationOperations accessType instead of String accessType as parameter of [{private void performAuthCheck()}}? This seems cleaner. MockWasbAuthorizerImpl.java:66 , let's use Map.Entry<> instead of HashMap.Entry<>. We should always use the interface type unless we have good reasons. Plus, this fails in Java 7 as the HashMap.Entry is private. Testing will happen and let's post test report here before commit.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Thanks Mingliang Liu.

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Thanks Mingliang Liu .
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for the patch. I really love the improvements in test. I'll review this week if no one else provides review.

        Show
        liuml07 Mingliang Liu added a comment - Thanks for the patch. I really love the improvements in test. I'll review this week if no one else provides review.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 15m 8s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 32s trunk passed
        +1 javadoc 0m 13s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        -0 checkstyle 0m 11s hadoop-tools/hadoop-azure: The patch generated 12 new + 43 unchanged - 6 fixed = 55 total (was 49)
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 0m 31s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 1m 23s hadoop-azure in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        22m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861887/HADOOP-14274-001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 60fb37cb6b4e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6eba792
        Default Java 1.8.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/testReport/
        modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 15m 8s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 32s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -0 checkstyle 0m 11s hadoop-tools/hadoop-azure: The patch generated 12 new + 43 unchanged - 6 fixed = 55 total (was 49) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 1m 23s hadoop-azure in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 22m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861887/HADOOP-14274-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 60fb37cb6b4e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6eba792 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            sisankar@microsoft.com Sivaguru Sankaridurg
            Reporter:
            sisankar@microsoft.com Sivaguru Sankaridurg
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development